Install and uninstall formulae with the internal API #20603
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
reviewed
Aug 29, 2025
| @@ -718,11 +718,14 @@ def self.autoremove(dry_run: false) | |||
| # the cache of installed formulae may no longer be valid. | |||
| Formula.clear_cache unless dry_run | |||
|
|
|||
| formulae = Formula.installed | |||
| formulae = Formula.installed(prefer_stub: true) | |||
There was a problem hiding this comment.
Anything dealing with installed formulae should just be able to use the formula from the Cellar rather than a stub?
Comment on lines
+1070
to
+1071
| json_formula = if Homebrew::EnvConfig.use_internal_api? | ||
| Homebrew::API::Formula.formula_json(name) |
There was a problem hiding this comment.
This definitely makes sense.
| @@ -26,7 +26,7 @@ def find_some_installed_dependents(kegs, casks: []) | |||
| kegs_by_source = kegs.group_by do |keg| | |||
| # First, attempt to resolve the keg to a formula | |||
| # to get up-to-date name and tap information. | |||
| f = keg.to_formula | |||
| f = keg.to_formula(prefer_stub: true) | |||
There was a problem hiding this comment.
Same deal with kegs: they should be able to use the formula file they have internally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised in slack, this PR includes the changes necessary to finally
brew installandbrew uninstallusing only the internal API.To test, run:
Importantly, the full
formula.jws.jsonfile was not downloaded during this process.