Skip to content

Conversation

bevanjkay
Copy link
Member

@bevanjkay bevanjkay commented Sep 2, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

After changes to utilise the download queue, the installation of "container dependencies" during brew audit were no longer working as expected. The Homebrew::Install.fetch_formulae method expects a formula installer to be passed to it, but a Formula was being passed instead.

brew audit sabaki --online --signing --cask

audit for sabaki: failed
 - exception while auditing sabaki: undefined method 'formula' for an instance of Formulary::FormulaNamespace3d483f559c610b6e653ea661e1a9bab902f1b0a7dc894c44d53ffb7d93a039a1::P7zip

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Sep 2, 2025
@mirhossain022786-eng

This comment was marked as spam.

Merged via the queue into main with commit bfb0a55 Sep 2, 2025
36 checks passed
@MikeMcQuaid MikeMcQuaid deleted the audit-container-deps branch September 2, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants