Skip to content

Conversation

alebcay
Copy link
Member

@alebcay alebcay commented Oct 26, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

So far, this seems to work on my local machine. We'll see how CI fares. Upstream notes that dotnet 7.x should support OpenSSL 3.

This PR does not un-deprecate dependents. Open to trying to un-deprecate everything in one try, but I think doing it separately hopefully allows for faster feedback from CI.

@alebcay alebcay added the long build Set a long timeout for formula testing label Oct 26, 2023
@github-actions github-actions bot added the icu4c ICU use is a significant feature of the PR or issue label Oct 26, 2023
@alebcay alebcay added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. and removed CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Oct 26, 2023
@github-actions github-actions bot added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. and removed CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Oct 26, 2023
@alebcay
Copy link
Member Author

alebcay commented Nov 3, 2023

The 13-arm64 failure is fixed in dotnet/runtime@b014ab8, and backported to 7.0.107.

source-build no longer supports macOS after ~7.0.105 (or, perhaps proper support has already been absent and we have been kludging something together to get us along to this point, but keeping up is proving to be onerous); macOS source-build support may return in .NET 9 - dotnet/source-build#2909.

@alebcay alebcay closed this Nov 3, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. icu4c ICU use is a significant feature of the PR or issue long build Set a long timeout for formula testing outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant