-
Notifications
You must be signed in to change notification settings - Fork 308
Fix: Enforce Scope-Based Uniqueness for Gateway Server Name, Gateway Server URL & Tool Name (Private/Team/Public visibility rules) #970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+583
−99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: Mihai Criveti <[email protected]>
a6096e9
to
b531fb7
Compare
vk-playground
pushed a commit
to vk-playground/mcp-context-forge
that referenced
this pull request
Sep 14, 2025
…Server URL & Tool Name (Private/Team/Public visibility rules) (IBM#970) * uniqueness Signed-off-by: rakdutta <[email protected]> * flake Signed-off-by: rakdutta <[email protected]> * alembic Signed-off-by: rakdutta <[email protected]> * alembic Signed-off-by: rakdutta <[email protected]> * pytest Signed-off-by: rakdutta <[email protected]> * pytest Signed-off-by: rakdutta <[email protected]> * pytest Signed-off-by: rakdutta <[email protected]> * pytest Signed-off-by: rakdutta <[email protected]> * flake Signed-off-by: rakdutta <[email protected]> * pytest Signed-off-by: rakdutta <[email protected]> * revert alembic script with main Signed-off-by: rakdutta <[email protected]> * alembic Signed-off-by: rakdutta <[email protected]> * fix lint error Signed-off-by: rakdutta <[email protected]> * fix lint error Signed-off-by: rakdutta <[email protected]> * rebase Signed-off-by: Mihai Criveti <[email protected]> --------- Signed-off-by: rakdutta <[email protected]> Signed-off-by: Mihai Criveti <[email protected]> Co-authored-by: Mihai Criveti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Reference issue #945)
Background / Issue
Previously, Gateway Server Name, Gateway Server URL, and Tool Name were validated with a global unique constraint.
Fix Implemented
Database Changes
(slug, owner_email, team_id)
for Gateway Server Name, Gateway Server URL, and Tool Nameslug
andurl
.Application Logic
(slug/url/tool_name, owner_email, team_id)
team_id
Expected Behavior After Fix
(slug/url/tool_name, owner_email, team_id)
(slug/url/tool_name, team_id)
(slug/url/tool_name)
globallyTesting / Verification
gw_name
,gw_url
,tool_name
.