🎨 Unmarks WEBSERVER_REALTIME_COLLABORATION as dev feature ⚠️

[pcrespov]

What do these changes do?

Remove "dev-feature" mark from WEBSERVER_REALTIME_COLLABORATION domain. Note that now WEBSERVER_REALTIME_COLLABORATION can still be explicitly disabled by setting it to WEBSERVER_REALTIME_COLLABORATION=null

Related issue/s

• resolves https://github.com/ITISFoundation/private-issues/issues/347

How to test

Dev-ops

• ⚠️ remove WEBSERVER_DEV_FEATURE=1 when release in staging

[pcrespov]

@mergify queue

[mergify]

queue

🟠 Waiting for conditions to match

• any of: [🔀 queue conditions]
  • all of: [📌 queue conditions of queue default]
    • any of: [🛡 GitHub branch protection]
      • check-neutral = deploy to dockerhub
      • check-skipped = deploy to dockerhub
      • check-success = deploy to dockerhub
    • any of: [🛡 GitHub branch protection]
      • check-neutral = system-tests
      • check-skipped = system-tests
      • check-success = system-tests
    • any of: [🛡 GitHub branch protection]
      • check-neutral = unit-tests
      • check-skipped = unit-tests
      • check-success = unit-tests
    • any of: [🛡 GitHub branch protection]
      • check-neutral = check OAS' are up to date
      • check-skipped = check OAS' are up to date
      • check-success = check OAS' are up to date
    • any of: [🛡 GitHub branch protection]
      • check-neutral = integration-tests
      • check-skipped = integration-tests
      • check-success = integration-tests
    • any of: [🛡 GitHub branch protection]
      • check-neutral = build-test-images (frontend) / build-test-images
      • check-skipped = build-test-images (frontend) / build-test-images
      • check-success = build-test-images (frontend) / build-test-images
    • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
    • #approved-reviews-by>=2
    • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
    • #changes-requested-reviews-by=0
    • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
    • #review-threads-unresolved=0
    • -conflict
    • -draft
    • base=master
    • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
    • label!=🤖-do-not-merge
    • label=🤖-automerge
    • any of: [🛡 GitHub branch protection]
      • check-success = SonarCloud Code Analysis
      • check-neutral = SonarCloud Code Analysis
      • check-skipped = SonarCloud Code Analysis
• -closed [📌 queue requirement]
• -conflict [📌 queue requirement]
• -draft [📌 queue requirement]
• any of: [📌 queue -> configuration change requirements]
  • -mergify-configuration-changed
  • check-success = Configuration changed

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.73%. Comparing base (bc3996b) to head (9af39fd).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8348      +/-   ##
==========================================
- Coverage   87.85%   84.73%   -3.13%     
==========================================
  Files        1945      760    -1185     
  Lines       75545    35002   -40543     
  Branches     1312      175    -1137     
==========================================
- Hits        66371    29659   -36712     
+ Misses       8779     5286    -3493     
+ Partials      395       57     -338     

Flag	Coverage Δ
integrationtests	63.94% <ø> (-0.11%)	⬇️
unittests	87.19% <ø> (+0.68%)	⬆️

Components	Coverage Δ
pkg_aws_library	∅ <ø> (∅)
pkg_celery_library	∅ <ø> (∅)
pkg_dask_task_models_library	∅ <ø> (∅)
pkg_models_library	∅ <ø> (∅)
pkg_notifications_library	∅ <ø> (∅)
pkg_postgres_database	∅ <ø> (∅)
pkg_service_integration	∅ <ø> (∅)
pkg_service_library	∅ <ø> (∅)
pkg_settings_library	∅ <ø> (∅)
pkg_simcore_sdk	76.84% <ø> (-8.20%)	⬇️
agent	∅ <ø> (∅)
api_server	∅ <ø> (∅)
autoscaling	∅ <ø> (∅)
catalog	∅ <ø> (∅)
clusters_keeper	∅ <ø> (∅)
dask_sidecar	∅ <ø> (∅)
datcore_adapter	∅ <ø> (∅)
director	∅ <ø> (∅)
director_v2	78.06% <ø> (-12.87%)	⬇️
dynamic_scheduler	∅ <ø> (∅)
dynamic_sidecar	81.87% <ø> (-8.59%)	⬇️
efs_guardian	∅ <ø> (∅)
invitations	∅ <ø> (∅)
payments	∅ <ø> (∅)
resource_usage_tracker	∅ <ø> (∅)
storage	∅ <ø> (∅)
webclient	∅ <ø> (∅)
webserver	87.92% <ø> (-0.14%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc3996b...9af39fd. Read the comment docs.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mergify]

🧪 CI Insights

Here's what we observed from your CI run for 9af39fd.

✅ Passed Jobs With Interesting Signals

Pipeline	Job	Signal	Health on master	Retries	🔍 CI Insights	📄 Logs
CI	system-tests	Base branch is broken, but the job passed. Looks like this might be a real fix 💪		0	View	View
	unit-tests	Base branch is broken, but the job passed. Looks like this might be a real fix 💪		0	View	View

[sanderegg]

thanks

[wvangeit]

Thx

[bisgaard-itis]

Thanks

[pcrespov]

@sanderegg can you please re-review the changes i did in the tests? When I unmarked the WEBSERVER_REALTIME_COLLABORATION as dev-feature, it automatically got activated in some of the tests suites e.g. services/web/server/tests/unit/with_dbs/02/test_projects_states_handlers.py leading to this tests failure

I thought of disabling back the feature for these tests, i.e. WEBSERVER_REALTIME_COLLABORATION=null, but instead I decided to modify the assertion (see my changes in the tests). I am not sure it is the best decision. What do you think about it?

1. should i enforce WEBSERVER_REALTIME_COLLABORATION=null so it is like before?
2. should i extend the tests parametrizing WEBSERVER_REALTIME_COLLABORATION to on/off to enrich the test or better i wait to lighten up the project tests before doing so?

thx in advance

[pcrespov]

@mergify queue

[mergify]

queue

🟠 Waiting for conditions to match

• -closed [📌 queue requirement]
• -conflict [📌 queue requirement]
• -draft [📌 queue requirement]
• any of: [📌 queue -> configuration change requirements]
  • -mergify-configuration-changed
  • check-success = Configuration changed
• any of: [🔀 queue conditions]
  • all of: [📌 queue conditions of queue default]
    • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
    • #approved-reviews-by>=2
    • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
    • #changes-requested-reviews-by=0
    • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
    • #review-threads-unresolved=0
    • -conflict
    • -draft
    • base=master
    • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
    • label!=🤖-do-not-merge
    • label=🤖-automerge
    • any of: [🛡 GitHub branch protection]
      • check-skipped = deploy to dockerhub
      • check-neutral = deploy to dockerhub
      • check-success = deploy to dockerhub
    • any of: [🛡 GitHub branch protection]
      • check-success = system-tests
      • check-neutral = system-tests
      • check-skipped = system-tests
    • any of: [🛡 GitHub branch protection]
      • check-success = unit-tests
      • check-neutral = unit-tests
      • check-skipped = unit-tests
    • any of: [🛡 GitHub branch protection]
      • check-success = check OAS' are up to date
      • check-neutral = check OAS' are up to date
      • check-skipped = check OAS' are up to date
    • any of: [🛡 GitHub branch protection]
      • check-success = integration-tests
      • check-neutral = integration-tests
      • check-skipped = integration-tests
    • any of: [🛡 GitHub branch protection]
      • check-success = build-test-images (frontend) / build-test-images
      • check-neutral = build-test-images (frontend) / build-test-images
      • check-skipped = build-test-images (frontend) / build-test-images
    • any of: [🛡 GitHub branch protection]
      • check-success = SonarCloud Code Analysis
      • check-neutral = SonarCloud Code Analysis
      • check-skipped = SonarCloud Code Analysis

[sanderegg]

discussed offline. all good thanks!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud