✨ [Frontend] Delete Functions #8351
Merged
+82
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f github.com:giancarloromeo/osparc-simcore into feature/delete-functions
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8351 +/- ##
==========================================
+ Coverage 86.76% 89.75% +2.99%
==========================================
Files 1771 1530 -241
Lines 68674 63279 -5395
Branches 1312 499 -813
==========================================
- Hits 59585 56797 -2788
+ Misses 8694 6353 -2341
+ Partials 395 129 -266
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
odeimaiz
added
t:enhancement
odeimaiz
requested review from
pcrespov,
sanderegg,
GitHK,
matusdrobuliak66 and
giancarloromeo
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR implements the ability to delete functions in the frontend, adding a force delete option to handle functions with associated jobs. The implementation includes both backend API changes and frontend UI components to support function deletion.
- Adds a
forcequery parameter to the delete function API endpoint to allow deletion of functions with associated jobs - Implements frontend UI for function deletion with confirmation dialogs and error handling for functions with jobs
- Introduces proper error handling for attempting to delete functions that have associated jobs without the force flag
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
services/web/server/src/simcore_service_webserver/functions/_functions_repository.py |
Adds logic to check for associated jobs and prevent deletion unless force flag is used |
services/web/server/src/simcore_service_webserver/functions/_functions_service.py |
Updates service layer to accept force parameter |
services/web/server/src/simcore_service_webserver/functions/_controller/_functions_rest.py |
Adds force query parameter handling to delete endpoint |
services/web/server/src/simcore_service_webserver/functions/_controller/_functions_rest_schemas.py |
Defines query parameter schema for force delete |
packages/models-library/src/models_library/functions_errors.py |
Adds new error class for functions with associated jobs |
services/static-webserver/client/source/class/osparc/store/Functions.js |
Implements deleteFunction method in the store |
services/static-webserver/client/source/class/osparc/data/Resources.js |
Adds delete endpoint configuration |
services/static-webserver/client/source/class/osparc/dashboard/StudyBrowser.js |
Adds function deletion UI components and handlers |
services/web/server/tests/unit/with_dbs/04/functions/test_functions_controller_rest.py |
Adds comprehensive tests for function deletion scenarios |
services/web/server/tests/unit/with_dbs/04/functions/conftest.py |
Adds test fixture for function with associated job |
|
|
@mergify queue |
🛑 Configuration not compatible with a branch protection settingThe branch protection setting |
GitHK
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR implements the ability to delete functions in the frontend, adding a force delete option to handle functions with associated jobs.
Related issue/s
How to test
Dev-ops