Skip to content

Conversation

kiri11
Copy link
Contributor

@kiri11 kiri11 commented Jul 4, 2024

Summary

After #879 got implemented, we can assume that most user codemods are loaded in this way instead of editing the LibCST source (it would be just pip installed). So -x flag is very important and should be mentioned in docs.

I am open to suggestions on how to improve the wording and also mention the built-in codemods and libcst.tool list better.

Test Plan

#shipit (just docs)

@facebook-github-bot
Copy link

Hi @kiri11!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 4, 2024
Copy link
Contributor

@zsol zsol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks! Note that you could always have loaded Codemods from arbitrary locations as long as you had a config file in the root of your repo and then listed the locations of the Codemods there.

But yeah with -x even that is not necessary anymore.

@zsol zsol merged commit 72701e4 into Instagram:main Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants