Skip to content

Conversation

hadialqattan
Copy link
Contributor

@hadialqattan hadialqattan commented Mar 20, 2025

Summary

Basically fixes #1279 by bumping minimum MacOS version from 10.9 (cibuildwheel default) to 10.12.

Rustc requires MACOSX_DEPLOYMENT_TARGET >= 3.12 while cibuildwheel sets the MACOSX_DEPLOYMENT_TARGET to 10.9 by default, if not specified by the user.

ref 0: cibuildwheel/macos.py

ref 1: rustc/src/platform-support/apple-darwin.md

@facebook-github-bot
Copy link

Hi @hadialqattan!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 20, 2025
@hadialqattan
Copy link
Contributor Author

Hey @zsol,

Kindly, could you help to to finalize this PR?

@hadialqattan
Copy link
Contributor Author

Btw, should I document this somewhere (e.g. changelog)?

@zsol
Copy link
Contributor

zsol commented Mar 22, 2025

Btw, should I document this somewhere (e.g. changelog)?

I'll take care of that. Thank you for the PR!

@zsol zsol merged commit 2c7834e into Instagram:main Mar 22, 2025
31 checks passed
ngoldbaum pushed a commit to ngoldbaum/LibCST that referenced this pull request Apr 8, 2025
@hadialqattan hadialqattan deleted the pr1316 branch May 2, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.6.0 has no intel macos wheels
3 participants