Remove pure parser #1371
Open
Remove pure parser #1371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
zsol
approved these changes
Jul 8, 2025
There was a problem hiding this comment.
This is a good start! I would personally probably separate the change out to three PRs:
- the entrypoints change
- clean up tests that are no longer relevant
- delete the old parser
But it's entirely up to you.
There are a bunch of additional stuff that can be cleaned up, like tests that get skipped with the native parser (these are typically error tests), or a large chunk of the ParserConfig and PartialParserConfig infrastructure. We could also move the utf8 conversion down to the rust layer which might help perf
| def test_valid(self, **kwargs: Any) -> None: | ||
| if not is_native() and kwargs.get("native_only", False): | ||
| self.skipTest("Disabled for native parser") | ||
| if "native_only" in kwargs: |
| parser: Optional[Callable[[str], cst.CSTNode]] = ( | ||
| parse_statement if is_native() else None | ||
| ) | ||
| parser: Optional[Callable[[str], cst.CSTNode]] = parse_statement |
There was a problem hiding this comment.
Suggested change
| parser: Optional[Callable[[str], cst.CSTNode]] = parse_statement | |
| parser: Callable[[str], cst.CSTNode] = parse_statement |
| } | ||
| ) | ||
| def test_parser( | ||
| self, *, code: str, expected: cst.Module, enabled_for_native: bool = True |
There was a problem hiding this comment.
The enabled_for_native param should also go away
| native_parse_statement: Optional[Callable[[str], cst.CSTNode]] = ( | ||
| parse_statement if is_native() else None | ||
| ) | ||
| native_parse_statement: Optional[Callable[[str], cst.CSTNode]] = parse_statement |
There was a problem hiding this comment.
Suggested change
| native_parse_statement: Optional[Callable[[str], cst.CSTNode]] = parse_statement | |
| native_parse_statement: Callable[[str], cst.CSTNode] = parse_statement |
| ) | ||
| def test_versions(self, **kwargs: Any) -> None: | ||
| if is_native() and not kwargs.get("expect_success", True): | ||
| if not kwargs.get("expect_success", True): |
There was a problem hiding this comment.
we should delete test cases that are marked with expect_success here
| parser_type = "native" if is_native() else "pure" | ||
| print(f"running tests with {parser_type!r} parser") | ||
|
|
||
| print("running tests with native parser") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#1370
Test Plan
CI