Skip to content

Fixes indented block position by PositionProvider (#1380) #1381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fixes indented block position by PositionProvider (#1380) #1381

wants to merge 3 commits into from

Conversation

AryazE
Copy link

@AryazE AryazE commented Jul 17, 2025

Summary

Added a check for ClassDef and FunctionDef nodes with decorators when they appear as the first node in an indented block.
In such cases, the state.record_syntactic_position is called with start_node being the first decorator of the class/function definition and not the definition itself.

Test Plan

Added two tests, one for ClassDef and one for FunctionDef in libcst/metadata/tests/test_position_provider.py under PositionProviderTest

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AryazE