-
Notifications
You must be signed in to change notification settings - Fork 6k
Move the ZipFIleSystemAccessor configuration from JSConfiguration to common klib configurations and add compiler arguments. #5477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There are two "merge" commits which are undesirable. The single meaningful commit should be added as a result of rebasing on top of fresh |
I would highly recommend to split the commit into two separate commits:
|
The commit message should contain a YT ticket number. It's better to put it onto a separate line. Example:
|
|
||
@Argument( | ||
value = "-Xklib-zip-file-accessor-cache-limit", | ||
description = "Size of cache to be used for the klib zip file accessor. Default is 0.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CLI key description does not specify the units in which the size is measured.
Also, it's unclear what does the default value ("0") exactly mean - disabled or unlimited?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the wordings, PTAL. I also think it should in general speed up the compiler, so I've setup the default value as 64. Please let me know if it makes sense.
compiler/cli/src/org/jetbrains/kotlin/cli/common/klibArguments.kt
Outdated
Show resolved
Hide resolved
compiler/cli/src/org/jetbrains/kotlin/cli/common/klibArguments.kt
Outdated
Show resolved
Hide resolved
...arguments/src/org/jetbrains/kotlin/arguments/description/CommonKlibBasedCompilerArguments.kt
Outdated
Show resolved
Hide resolved
compiler/cli/cli-js/src/org/jetbrains/kotlin/cli/js/K2JSCompiler.kt
Outdated
Show resolved
Hide resolved
I think, it worth adding
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JVM-related changes looks good, thanks
compiler/cli/cli-js/src/org/jetbrains/kotlin/cli/js/K2JSCompiler.kt
Outdated
Show resolved
Hide resolved
GH shows that there is a source conflict. Please rebase on fresh |
Enabling cached ZipFileSystemAccessor for Kotlin Native.
Closes: https://youtrack.jetbrains.com/issue/KT-79675/