KT-20357: Add getOrElse sample for Collections #5482
Conversation
hondaya14
force-pushed
the
sample-collections
branch
from
c033094 to
ccd949a
Compare
hondaya14
force-pushed
the
sample-collections
branch
from
ccd949a to
045cbe0
Compare
fzhinkin
added
the
Standard Library Sample
| @@ -1467,6 +1467,8 @@ public inline fun CharArray.firstOrNull(predicate: (Char) -> Boolean): Char? { | |||
|
|
|||
| /** | |||
| * Returns an element at the given [index] or the result of calling the [defaultValue] function if the [index] is out of bounds of this array. | |||
| * | |||
| * @sample samples.collections.Collections.Elements.getOrElse | |||
There was a problem hiding this comment.
It would be nice to provide dedicated samples for array types (like it was done for contentEquals, for example: 658323f)
There was a problem hiding this comment.
I added samples for array types. I opted not to introduce per-type methods (e.g. contentEquals), since that would be verbose and slightly reduce readability.
(ref: bdcf70b)
I’m unsure about the class structure—especially the sample subclass categorization—so I may be mistaken. Feedback would be appreciated.
There was a problem hiding this comment.
I opted not to introduce per-type methods (e.g. contentEquals), since that would be verbose and slightly reduce readability.
That's fine, thanks. We discussed it with colleagues and decided to stick to this approach for now.
|
@fzhinkin |
| @@ -1467,6 +1467,8 @@ public inline fun CharArray.firstOrNull(predicate: (Char) -> Boolean): Char? { | |||
|
|
|||
| /** | |||
| * Returns an element at the given [index] or the result of calling the [defaultValue] function if the [index] is out of bounds of this array. | |||
| * | |||
| * @sample samples.collections.Collections.Elements.getOrElse | |||
There was a problem hiding this comment.
I opted not to introduce per-type methods (e.g. contentEquals), since that would be verbose and slightly reduce readability.
That's fine, thanks. We discussed it with colleagues and decided to stick to this approach for now.
|
Merged: 53be3ba |
Added a sample function for
getOrElseinCollections.There was already a sample for
Map, but none forCollections.Related issue: https://youtrack.jetbrains.com/issue/KT-20357