-
-
Notifications
You must be signed in to change notification settings - Fork 349
Traefik v3 Swarm Example #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
bdd727e
to
d152646
Compare
d152646
to
acbdea2
Compare
properly 401'd the docker login check. Reference: https://mirilittleme.medium.com/how-docker-login-works-under-the-hood-42225601843c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thank you for you contribution. I added some comments 😄
networks: | ||
- frontend | ||
|
||
### Redis Container |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If redis is not required for the example to work, please remove it too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The registry uses redis. I wanted to make a fully functional example that you can "one-click" and you can be up and running, almost zero configuration. In that light, I propose to keep.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The minimal configuration does not need redis, the basic configuration is using volume disk. Redis is used as a blobdescriptor
cache that can be replaced by a simple inmemory
cache
This PR combines (and supercedes) the ideas of #380, #396 and #419 and updates the example to use Traefik v3.
It is designed to be a "detailed quickstart" for a homelab or development environment and can easily be broken apart for larger more-production environments.
For the most part, this configuration file is about configuring Traefik and the support containers, and less about configuring this container.
I have followed your commit naming convention and files are linted and documented as much as possible to be helpful for those who wish to modify the configuration.
Features:
https://registry.contoso.com
)Unfortunately, there were just too many updates and changes to continue the work of any other committers and extend their PRs. I did however, add a few names to the Contributors list of the
README.md
file as a consolation.