-
Notifications
You must be signed in to change notification settings - Fork 86
add back fireworks (JUD-1951) #552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @Mandolaro, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request reintroduces and enhances the tracing capabilities for Fireworks Large Language Models within the system. The changes enable the platform to properly monitor and log interactions with Fireworks LLM services, ensuring that usage data and responses are captured and formatted correctly for analysis. This is crucial for maintaining comprehensive observability across different LLM providers.
Highlights
- Fireworks LLM Integration: Added comprehensive support for tracing Fireworks LLM API calls, including direct client instances and those used within
TrainableModel
. - Provider Detection and Data Extraction: Implemented logic to detect Fireworks clients and extract content, usage, and token information from Fireworks streaming chunks and responses.
- Model Name Standardization: Ensured that Fireworks model names are consistently prefixed with "fireworks_ai/" for standardized tracing.
- API Call Wrapping: Applied wrapping to
chat.completions.create
andcompletions.create
methods for both synchronous and asynchronous Fireworks clients and LLM instances.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with π and π on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. β©
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for Fireworks AI tracing. The changes are extensive, touching provider detection, data extraction, and client wrapping logic. Overall, the implementation is on the right track, but I've identified several areas for improvement regarding code duplication, robustness, and clarity. Key suggestions include refactoring for safer attribute access to prevent potential runtime errors, removing redundant code blocks, and simplifying logic for better maintainability.
π Summary
β Checklist