Cleanup indices info + better docs #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #342 +/- ##
==========================================
+ Coverage 90.23% 90.27% +0.04%
==========================================
Files 9 9
Lines 1331 1337 +6
==========================================
+ Hits 1201 1207 +6
Misses 130 130
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Before making this public I wanted to ensure that we had control over the construction of `IndicesInfo` so it was guaranteed to be valid. Now it has inner struct constructors only. Also provided `ndims_index` and `ndims_shape` so all information can be accessed without directly looking at `IndicesInfo`'s parametric typing.
|
@ChrisRackauckas , are these errors expected right now https://github.com/JuliaArrays/ArrayInterface.jl/runs/8166027000?check_suite_focus=true |
|
Yes, sorry about that. That failure is unrelated and should disappear later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.