Skip to content

Fix BigFloat QR instance and test better #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 31, 2023
Merged

Fix BigFloat QR instance and test better #406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f2e5d5a
Fix BigFloat QR instance and test better
ChrisRackauckas Mar 31, 2023
f65ab8d
one more
ChrisRackauckas Mar 31, 2023
c7dacc9
fix typo
ChrisRackauckas Mar 31, 2023
cc01b00
bigfloat factorizations may not exist
ChrisRackauckas Mar 31, 2023
a26b85a
wrong type check
ChrisRackauckas Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/ArrayInterface.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,6 +576,10 @@ function qr_instance(A::Matrix{T}) where {T}
LinearAlgebra.QRCompactWYQ(zeros(T,0,0),zeros(T,0,0))
end

function qr_instance(A::Matrix{BigFloat})
LinearAlgebra.QR(zeros(BigFloat,0,0),zeros(BigFloat,0))
end

# Could be optimized but this should work for any real case.
function qr_instance(jac_prototype::SparseMatrixCSC)
qr(sparse(rand(1,1)))
Expand Down
15 changes: 15 additions & 0 deletions test/core.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,3 +259,18 @@ end
@test !ArrayInterface.ensures_sorted([])
@test ArrayInterface.ensures_sorted(1:10)
end

@testset "linearalgebra instances" begin
for A in [rand(2,2), rand(Float32,2,2), rand(BigFloat,2,2)]

@test ArrayInterface.lu_instance(A) isa typeof(lu(A))
@test ArrayInterface.qr_instance(A) isa typeof(qr(A))

if !(eltype(A) <: BigFloat)
@test ArrayInterface.bunchkaufman_instance(A) isa typeof(bunchkaufman(A' * A))
@test ArrayInterface.cholesky_instance(A) isa typeof(cholesky(A' * A))
@test ArrayInterface.ldlt_instance(A) isa typeof(ldlt(SymTridiagonal(A' * A)))
@test ArrayInterface.svd_instance(A) isa typeof(svd(A))
end
end
end