LibWeb: Throw range error when initial is greater than maximum #6122
+191
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when constructing WebAssembly.Memory if initial is greater than maximum a range error will be thrown. fixes https://wpt.fyi/results/wasm/jsapi/memory/constructor.any.worker.html?product=ladybird Initial value exceeds maximum
me-it-is
force-pushed
the
fix-construct-out-of-range
branch
from
90378aa to
5873129
Compare
|
It seems like the sanitizers failing is unrelated to this pr. |
gmta
reviewed
Sep 9, 2025
Comment on lines
+26
to
+31
| // 3. If maximum is not empty and maximum < initial, throw a RangeError exception. | ||
| if (descriptor.maximum.has_value()) { | ||
| if (descriptor.maximum.value() < descriptor.initial) { | ||
| return vm.throw_completion<JS::RangeError>("Initial is larger than maximum."sv); | ||
| } | ||
| } |
There was a problem hiding this comment.
You don't need to nest these conditions:
if (descriptor.maximum.has_value() && descriptor.maximum.value() < descriptor.initial)
return vm.throw_completion<JS::RangeError>("Initial is larger than maximum."sv);
alimpfard
reviewed
Sep 9, 2025
| @@ -23,6 +23,13 @@ WebIDL::ExceptionOr<GC::Ref<Memory>> Memory::construct_impl(JS::Realm& realm, Me | |||
| auto& vm = realm.vm(); | |||
There was a problem hiding this comment.
Please rewrap the commit message and use proper capitalisation.
(maybe something like "Fixes the 'Initial value exceeds maximum' test in\n<that url>"?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when constructing WebAssembly.Memory if initial is greater than maximum a range error will be thrown.
fixes
https://wpt.fyi/results/wasm/jsapi/memory/constructor.any.worker.html?product=ladybird Initial value exceeds maximum