Allow MLFlowLogger
to work with mlflow-skinny
#16513
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
mlflow-skinny is a variant of the mlflow library that installs the bare-minimum required for tracking: https://pypi.org/project/mlflow-skinny/
Even though this should be enough to enable the MLFlowLogger, it doesn't work because:
https://github.com/Lightning-AI/lightning/blob/4a802e00a843264afd5aea023d8475d4f1b4d360/src/pytorch_lightning/loggers/mlflow.py#L40
checks that precisely the
mlflow
library is installed.This PR looses the restriction to check for the
mlflow-skinny
library too.Fixes #16486
Does your PR introduce any breaking changes? If yes, please list them.
If there are users that have the
mlflow-skinny
library installed and are counting on the MLFlowLogger not working, but I can't see why that would be the case...Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Yup :)
Make sure you had fun coding 🙃