Skip to content

Support MLFlowLogger with only the mlflow-skinny dependency installed #16486

@dconathan

Description

@dconathan

Bug description

Sorry not sure to label this as a "feature" or a "bug":

mlflow-skinny is a variant of the mlflow library that installs the bare-minimum required for tracking: https://pypi.org/project/mlflow-skinny/

As far as I can tell, this meets the requirements for using the MLFlowLogger, but currently it doesn't work because:

https://github.com/Lightning-AI/lightning/blob/4a802e00a843264afd5aea023d8475d4f1b4d360/src/pytorch_lightning/loggers/mlflow.py#L40

checks that precisely the mlflow library is installed. If this line were replaced with:

_MLFLOW_AVAILABLE = RequirementCache("mlflow>=1.0.0") or RequirementCache("mlflow-skinny>=1.0.0")

It seems to work fine.

Should I make a PR for this? Would we want to add separate tests for mlflow and mlflow-skinny environments?

How to reproduce the bug

No response

Error messages and logs

No response

Environment

No response

More info

No response

cc @Borda

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions