Skip to content

Commit 98a5188

Browse files
KAVYANSHTYAGIBorda
authored andcommitted
Respect verbose=False in seed_everything when no seed is provided (#21161)
* Update test_mlflow.py * test_mlflow.py * Respect verbose flag in seed_everything * Apply suggestions from code review --------- Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit d6499ed)
1 parent adc72e2 commit 98a5188

File tree

3 files changed

+13
-1
lines changed

3 files changed

+13
-1
lines changed

src/lightning/fabric/CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
1818
- Fixed with adding a missing device id for pytorch 2.8 ([#21105](https://github.com/Lightning-AI/pytorch-lightning/pull/21105))
1919

2020

21+
- Respect `verbose=False` in `seed_everything` when no seed is provided
22+
23+
2124
## [2.5.4] - 2025-08-29
2225

2326
### Changed

src/lightning/fabric/utilities/seed.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@ def seed_everything(seed: Optional[int] = None, workers: bool = False, verbose:
4040
env_seed = os.environ.get("PL_GLOBAL_SEED")
4141
if env_seed is None:
4242
seed = 0
43-
rank_zero_warn(f"No seed found, seed set to {seed}")
43+
if verbose:
44+
rank_zero_warn(f"No seed found, seed set to {seed}")
4445
else:
4546
try:
4647
seed = int(env_seed)

tests/tests_fabric/utilities/test_seed.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,14 @@ def test_seed_everything_accepts_valid_seed_from_env():
7272
assert seed_everything() == 17
7373

7474

75+
@mock.patch.dict(os.environ, {}, clear=True)
76+
def test_seed_everything_non_verbose_no_warning():
77+
"""Ensure that no warning is emitted when verbose is False and no seed is provided."""
78+
with warnings.catch_warnings(record=True) as caught:
79+
seed_everything(verbose=False)
80+
assert caught == []
81+
82+
7583
def test_reset_seed_no_op():
7684
"""Test that the reset_seed function is a no-op when seed_everything() was not used."""
7785
assert "PL_GLOBAL_SEED" not in os.environ

0 commit comments

Comments
 (0)