-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Respect verbose=False
in seed_everything
when no seed is provided
#21161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21161 +/- ##
=======================================
Coverage 87% 87%
=======================================
Files 269 269
Lines 23595 23596 +1
=======================================
+ Hits 20579 20580 +1
Misses 3016 3016 |
Borda
reviewed
Sep 4, 2025
Borda
approved these changes
Sep 4, 2025
SkafteNicki
approved these changes
Sep 4, 2025
Borda
pushed a commit
that referenced
this pull request
Sep 4, 2025
…#21161) * Update test_mlflow.py * test_mlflow.py * Respect verbose flag in seed_everything * Apply suggestions from code review --------- Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit d6499ed)
lantiga
pushed a commit
that referenced
this pull request
Sep 5, 2025
…#21161) * Update test_mlflow.py * test_mlflow.py * Respect verbose flag in seed_everything * Apply suggestions from code review --------- Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit d6499ed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates Fabric’s
seed_everything
to respect theverbose=False
flag when no seed is provided.Previously, even with
verbose=False
, the function emitted a warning ("No seed found, seed set to 0"
). This PR ensures that:verbose=False
, no warnings or logs are emitted if the seed defaults to0
.verbose=True
, the warning is still shown for visibility.verbose=False
.Motivation and context
seed_everything
with the meaning of theverbose
flag across the codebase.verbose=False
to silence outputs.Dependencies
None
Does your PR introduce any breaking changes?
No — functionality is unchanged, only logging behavior is adjusted.
PR review
Community members are welcome to review this PR. The change is self-contained and low risk.
Checklist
test_seed_everything_non_verbose_no_warning
)