Skip to content

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Jan 20, 2022

What does this PR do?

Addresses #11443 (comment)

No need to update the changelog since strategy hasn't been released yet?

Does your PR introduce any breaking changes? If yes, please list them.

  • Strategy.lr_schedulers is renamed to Strategy.lr_scheduler_configs.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @rohitgr7 @akihironitta

@mergify mergify bot removed the has conflicts label Jan 24, 2022
@akihironitta akihironitta changed the title Rename lr_schedulers to lr_scheduler_configs Rename Strategy.lr_schedulers to Strategy.lr_scheduler_configs Jan 24, 2022
@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #11549 (e310573) into master (92c22ae) will decrease coverage by 4%.
The diff coverage is 93%.

❗ Current head e310573 differs from pull request most recent head f7ccd54. Consider uploading reports for the commit f7ccd54 to get more accurate results

@@           Coverage Diff            @@
##           master   #11549    +/-   ##
========================================
- Coverage      92%      88%    -4%     
========================================
  Files         194      194            
  Lines       16947    16947            
========================================
- Hits        15562    14948   -614     
- Misses       1385     1999   +614     

Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I'd say we should add this to the CHANGELOG as "Changed"

@mergify mergify bot added the ready PRs ready to be merged label Jan 24, 2022
@awaelchli awaelchli enabled auto-merge (squash) January 29, 2022 12:09
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any depreciation via property?

@awaelchli awaelchli merged commit fbc1f9f into master Feb 2, 2022
@awaelchli awaelchli deleted the refactor/rename-lr_scheduler_config branch February 2, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants