-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[CLI] add support for listing apps #13987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
2ad15ae
to
1d993b4
Compare
1d993b4
to
0da53f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! Some minor change requests but since it's merging as "experimental", I don't want to block the PR. The exception handling is something I think we should do now though, but again if you are keeping it for later, please track that in a ticket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accept to unblock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock as I am signing off
0da53f7
to
6503a2a
Compare
What does this PR do?
This PR changes the CLI to add support for listing apps. For our launch of BYOC support we want to be able to list apps and also filter by cluster which executes the application.
listing apps
the
--cluster-id
flag can be passed to list only apps in a specific cluster:Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda @tchaton @rohitgr7