Skip to content

Conversation

robertomest
Copy link
Contributor

@robertomest robertomest commented Aug 19, 2022

What does this PR do?

Fixes #14209

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 19, 2022
@carmocca carmocca added bug Something isn't working community This PR is from the community labels Aug 19, 2022
@carmocca carmocca added this to the pl:1.7.x milestone Aug 19, 2022
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you :)

@mergify mergify bot added the ready PRs ready to be merged label Aug 21, 2022
@awaelchli awaelchli enabled auto-merge (squash) August 22, 2022 10:04
@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #14317 (1dcb94c) into master (1a3fe39) will increase coverage by 15%.
The diff coverage is 100%.

❗ Current head 1dcb94c differs from pull request most recent head 1dcc5eb. Consider uploading reports for the commit 1dcc5eb to get more accurate results

@@            Coverage Diff            @@
##           master   #14317     +/-   ##
=========================================
+ Coverage      61%      76%    +15%     
=========================================
  Files         331      332      +1     
  Lines       26637    26891    +254     
=========================================
+ Hits        16351    20429   +4078     
+ Misses      10286     6462   -3824     

@mergify mergify bot added has conflicts ready PRs ready to be merged and removed ready PRs ready to be merged has conflicts labels Aug 25, 2022
@mergify mergify bot added ready PRs ready to be merged and removed ready PRs ready to be merged labels Aug 27, 2022
auto-merge was automatically disabled September 1, 2022 14:06

Base branch was modified

@awaelchli awaelchli enabled auto-merge (squash) September 5, 2022 08:13
@awaelchli awaelchli merged commit ed0164a into Lightning-AI:master Sep 5, 2022
krshrimali pushed a commit that referenced this pull request Sep 6, 2022
…4317)


Co-authored-by: Roberto Estevão <[email protected]>
Co-authored-by: Rohit Gupta <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>
krshrimali pushed a commit that referenced this pull request Sep 6, 2022
…4317)


Co-authored-by: Roberto Estevão <[email protected]>
Co-authored-by: Rohit Gupta <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>
lexierule pushed a commit that referenced this pull request Sep 6, 2022
…4317)


Co-authored-by: Roberto Estevão <[email protected]>
Co-authored-by: Rohit Gupta <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>
@robertomest robertomest deleted the bugfix/14209_num_stepping_batches branch September 8, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working community This PR is from the community pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trainer training batches estimation for map-style datasets seems wrong
6 participants