Skip to content

Conversation

Borda
Copy link
Member

@Borda Borda commented Sep 6, 2022

What does this PR do?

prepare for the v0.6 release

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@Borda Borda added the release label Sep 6, 2022
@Borda Borda requested a review from narJH27 September 6, 2022 19:56
@Borda Borda requested review from tchaton and manskx as code owners September 6, 2022 19:56
@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Sep 6, 2022
@Borda Borda added this to the app:0.6 milestone Sep 6, 2022
@mergify mergify bot added the ready PRs ready to be merged label Sep 7, 2022
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let’s get S3 Drives out in short order as well.

@Borda Borda changed the base branch from master to release/app September 8, 2022 09:02
@Borda Borda changed the base branch from release/app to master September 8, 2022 09:05
@Borda Borda changed the base branch from master to release/app September 8, 2022 09:05
Co-authored-by: Adrian Wälchli <[email protected]>
@Borda Borda enabled auto-merge (squash) September 8, 2022 09:07
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #14566 (4f9ee0e) into release/app (9537444) will decrease coverage by 25%.
The diff coverage is 100%.

❗ Current head 4f9ee0e differs from pull request most recent head ac197c1. Consider uploading reports for the commit ac197c1 to get more accurate results

@@              Coverage Diff               @@
##           release/app   #14566     +/-   ##
==============================================
- Coverage           85%      60%    -25%     
==============================================
  Files              358      358             
  Lines            27083    27033     -50     
==============================================
- Hits             23081    16327   -6754     
- Misses            4002    10706   +6704     

@Borda Borda disabled auto-merge September 8, 2022 09:33
@Borda Borda enabled auto-merge (squash) September 8, 2022 09:40
@Borda Borda disabled auto-merge September 8, 2022 11:41
@Borda Borda merged commit 9251269 into release/app Sep 8, 2022
@Borda Borda deleted the app/0.6 branch September 8, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package ready PRs ready to be merged release
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants