Skip to content

Conversation

awaelchli
Copy link
Contributor

What does this PR do?

Adds the DDP family of strategies supported in Lite.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

awaelchli and others added 30 commits September 7, 2022 22:25
@mergify mergify bot removed the ready PRs ready to be merged label Sep 14, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Sep 14, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Sep 14, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Sep 14, 2022
@awaelchli awaelchli enabled auto-merge (squash) September 14, 2022 23:47
@awaelchli awaelchli merged commit deca6cc into master Sep 15, 2022
@awaelchli awaelchli deleted the lite/strategies-ddp branch September 15, 2022 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package priority: 0 High priority task ready PRs ready to be merged refactor strategy
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants