Skip to content

Conversation

krshrimali
Copy link
Contributor

@krshrimali krshrimali commented Sep 16, 2022

This PR was closed in the favor of: #14746

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

dependabot bot and others added 15 commits September 16, 2022 14:38
…2.8.3 in /requirements (#14585)

Update s3fs requirement in /requirements

Updates the requirements on [s3fs](https://github.com/fsspec/s3fs) to permit the latest version.
- [Release notes](https://github.com/fsspec/s3fs/releases)
- [Changelog](https://github.com/fsspec/s3fs/blob/main/release-procedure.md)
- [Commits](fsspec/s3fs@2022.5.0...2022.8.2)

---
updated-dependencies:
- dependency-name: s3fs
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Removes timeout from streamlit e2e test
We have a timeout on the app view which waits for the button but it causes a refresh on the page which causes playwright to miss the button on each refresh.
we can remove the timeout altogether since we have a time limit on the test itself in the CI setup

Co-authored-by: thomas chaton <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…14666)

* Update traitlets requirement from <5.2.0 as strict in /requirements

Co-authored-by: Jirka Borovec <[email protected]>
* Traitlets >= 5.3.0
* Apply suggestions from code review

Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Bump lightning cloud for memory leak fix (#14697)
- updates the Lightning App docs theme to the one without Pytorch Lightning docs Google Tag Manager hardcoded
- sets the GTM id in the conf.py for Lightning App docs
* Update installation

Updates to use python -m pip install -U lightning and adds troubleshooting note

* Apply suggestions from code review

Co-authored-by: Jirka Borovec <[email protected]>
@krshrimali krshrimali changed the base branch from master to release/app September 16, 2022 09:23
@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Sep 16, 2022
@awaelchli awaelchli added this to the app:0.6.x milestone Sep 16, 2022
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #14745 (ff8e4e9) into release/app (9251269) will decrease coverage by 0%.
The diff coverage is 49%.

@@              Coverage Diff              @@
##           release/app   #14745    +/-   ##
=============================================
- Coverage           60%      60%    -0%     
=============================================
  Files              358      359     +1     
  Lines            27033    27149   +116     
=============================================
+ Hits             16330    16375    +45     
- Misses           10703    10774    +71     

@krshrimali
Copy link
Contributor Author

About the meta-pkg failures, can anyone help if they are legit? I don't see _module_available being used though in the mentioned file: https://github.com/Lightning-AI/lightning/blob/release/app-0.6.1/src/lightning_app/utilities/imports.py.

Action: https://github.com/Lightning-AI/lightning/actions/runs/3066780836/jobs/4952342861

  File "C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\site-packages\lightning\app\__init__.py", line 43, in <module>
    from lightning_app.utilities.imports import _module_available  # noqa: E402
ImportError: cannot import name '_module_available' from 'lightning_app.utilities.imports' (C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\site-packages\lightning_app\utilities\imports.py)

@krshrimali
Copy link
Contributor Author

Closing this in favor of: #14746

@krshrimali krshrimali closed this Sep 16, 2022
@krshrimali krshrimali deleted the release/app-0.6.1 branch September 16, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package release
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

10 participants