Skip to content

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Sep 16, 2022

What does this PR do?

Follow up to #14300 for Lite's Connector.
Resolves the corresponding TODO in the code.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @justusschock @awaelchli @rohitgr7 @tchaton @carmocca

@awaelchli awaelchli self-assigned this Sep 16, 2022
@awaelchli awaelchli added fabric lightning.fabric.Fabric refactor labels Sep 16, 2022
@awaelchli awaelchli added this to the pl:1.8 milestone Sep 16, 2022
@awaelchli awaelchli marked this pull request as ready for review September 17, 2022 22:02
@awaelchli awaelchli added the priority: 1 Medium priority task label Sep 17, 2022
@codecov
Copy link

codecov bot commented Sep 17, 2022

Codecov Report

Merging #14761 (df8240b) into master (35c65b0) will increase coverage by 1%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #14761     +/-   ##
=========================================
+ Coverage      84%      85%     +1%     
=========================================
  Files         395      276    -119     
  Lines       28805    21120   -7685     
=========================================
- Hits        24087    17972   -6115     
+ Misses       4718     3148   -1570     

@mergify mergify bot added the ready PRs ready to be merged label Sep 18, 2022
@awaelchli awaelchli merged commit 1092265 into master Sep 18, 2022
@awaelchli awaelchli deleted the lite/slurm-check branch September 18, 2022 18:01
rohitgr7 pushed a commit that referenced this pull request Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fabric lightning.fabric.Fabric priority: 1 Medium priority task ready PRs ready to be merged refactor
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants