Skip to content

addition to App 0.7 #15219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2022
Merged

addition to App 0.7 #15219

merged 1 commit into from
Oct 20, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 20, 2022 •
edited
Loading

What does this PR do?

concat...

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@tchaton @Borda
[App] Pass LightningWork to LightningApp (#15215)
37452e8 
* update

* update

* update

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

* ll

Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Jirka <[email protected]>
Co-authored-by: Luca Antiga <[email protected]>

(cherry picked from commit 8ec7ddf)
@Borda Borda added release app (removed) Generic label for Lightning App package labels Oct 20, 2022
@Borda Borda added this to the future milestone Oct 20, 2022
@Borda Borda modified the milestones: future, app:0.7 Oct 20, 2022
tchaton
tchaton approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@williamFalcon williamFalcon merged commit 65d29f0 into release/app Oct 20, 2022
@williamFalcon williamFalcon deleted the releasing-app branch October 20, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchaton tchaton tchaton approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@manskx manskx Awaiting requested review from manskx

@hhsecond hhsecond Awaiting requested review from hhsecond

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

Assignees
No one assigned
Labels
app (removed) Generic label for Lightning App package release
Projects
None yet
Milestone
app:0.7
Development

Successfully merging this pull request may close these issues.
3 participants
@Borda @tchaton @williamFalcon