Skip to content

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Oct 26, 2022

What does this PR do?

Fixes #12957

We warn accordingly when the input example format is not supported by TensorBoard for tracing.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @awaelchli @edward-io @rohitgr7

@awaelchli awaelchli added bug Something isn't working logger: tensorboard labels Oct 26, 2022
@awaelchli awaelchli added this to the v1.8.x milestone Oct 26, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Oct 26, 2022
@awaelchli awaelchli self-assigned this Oct 26, 2022
@awaelchli awaelchli marked this pull request as ready for review October 26, 2022 02:57
@awaelchli awaelchli added the community This PR is from the community label Oct 26, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Nov 2, 2022
@awaelchli awaelchli enabled auto-merge (squash) November 2, 2022 18:35
@mergify mergify bot added the ready PRs ready to be merged label Nov 2, 2022
@awaelchli awaelchli merged commit e52d6c5 into master Nov 2, 2022
@awaelchli awaelchli deleted the bugfix/tensorboard-loggraph branch November 2, 2022 21:10
Borda pushed a commit that referenced this pull request Nov 5, 2022
lexierule pushed a commit that referenced this pull request Nov 10, 2022
@awaelchli awaelchli added fun Staff contributions outside working hours - to differentiate from the "community" label and removed community This PR is from the community labels Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fun Staff contributions outside working hours - to differentiate from the "community" label logger: tensorboard pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Inconsistent example_input_array handling
3 participants