-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Periodically sync database to the drive #15441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0f274f5
to
8c2491e
Compare
e26bb49
to
61d2b0d
Compare
8be9861
to
0840888
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What will happen if the sync process takes longer than the interval?
The copy and the interval are sequential and all calls are blocking, so the interval indicates how much time will elapse before a new copy is performed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition !
(cherry picked from commit 1696027)
(cherry picked from commit 1696027)
What does this PR do?
Currently the database component syncs to the drive
on_exit
, which will also be triggered in case of an exception. In order to further ensure that data is not lost in case of an unhandled crash, this PR introduces periodic sync'ing of the database with a set time interval.Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda