Skip to content

Conversation

lantiga
Copy link
Collaborator

@lantiga lantiga commented Nov 1, 2022

What does this PR do?

If connect is called using the id, the connect.txt file ends up containing the app id both in the first and the second line. This makes commands (like show logs) that assume the first entry is the name fail.

This PR fixes this by ensuring that the first entry is the app name and the second entry is the app id.

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Nov 1, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@lantiga lantiga modified the milestones: v1.9, v1.8.x Nov 2, 2022
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify mergify bot added the ready PRs ready to be merged label Nov 2, 2022
@awaelchli awaelchli added the bug Something isn't working label Nov 2, 2022
@awaelchli awaelchli enabled auto-merge (squash) November 2, 2022 22:11
@awaelchli awaelchli force-pushed the fix_connect_entries branch from 240368a to 6c4a074 Compare November 2, 2022 22:11
@awaelchli awaelchli merged commit fa2951b into master Nov 3, 2022
@awaelchli awaelchli deleted the fix_connect_entries branch November 3, 2022 13:30
Borda added a commit that referenced this pull request Nov 5, 2022
Co-authored-by: Luca Antiga <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: awaelchli <[email protected]>
(cherry picked from commit fa2951b)
lexierule pushed a commit that referenced this pull request Nov 10, 2022
Co-authored-by: Luca Antiga <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: awaelchli <[email protected]>
(cherry picked from commit fa2951b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants