Skip to content

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Nov 2, 2022

What does this PR do?

Same as #15457 but for doctest. See the failing run https://github.com/Lightning-AI/lightning/actions/runs/3373154980/jobs/5597446136 in PR #15301

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @carmocca @akihironitta @Borda

@awaelchli awaelchli added the ci Continuous Integration label Nov 2, 2022
@awaelchli awaelchli added this to the v1.8.x milestone Nov 2, 2022
@Borda Borda enabled auto-merge (squash) November 2, 2022 09:46
@mergify mergify bot added the ready PRs ready to be merged label Nov 2, 2022
@awaelchli awaelchli disabled auto-merge November 2, 2022 09:57
@Borda Borda merged commit 2fccd1e into master Nov 2, 2022
@Borda Borda deleted the ci/arbitrary-branch-name branch November 2, 2022 10:07
@Borda Borda mentioned this pull request Nov 2, 2022
12 tasks
@awaelchli
Copy link
Contributor Author

Why did you merge this :(I disabled auto merge. It is not working, as you can see I was testing it here: #15301

@Borda
Copy link
Member

Borda commented Nov 2, 2022

Why did you merge this :(I disabled auto merge. It is not working, as you can see I was testing it here: #15301

it was my bad I checked and seems fine, did not realize the names as the GH's diff was too small... my had :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants