Skip to content

Conversation

ethanwharris
Copy link
Member

@ethanwharris ethanwharris commented Nov 3, 2022

What does this PR do?

Avoid checking the lightning version / enforcing consistent environment when running in the cloud.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@ethanwharris ethanwharris added bug Something isn't working app (removed) Generic label for Lightning App package app:cli labels Nov 3, 2022
@ethanwharris ethanwharris added this to the v1.9 milestone Nov 3, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Nov 3, 2022
@Borda Borda merged commit f5d67d7 into master Nov 3, 2022
@Borda Borda deleted the bugfix/cloud_version_check branch November 3, 2022 14:02
Borda pushed a commit that referenced this pull request Nov 5, 2022
Only check versions / env when not in the cloud

(cherry picked from commit f5d67d7)
lexierule pushed a commit that referenced this pull request Nov 10, 2022
Only check versions / env when not in the cloud

(cherry picked from commit f5d67d7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants