-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[App] Expose Run Work Executor #15561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g-AI/lightning into add_multi_node_examples
…g-AI/lightning into add_multi_node_examples
ethanwharris
approved these changes
Nov 8, 2022
justusschock
approved these changes
Nov 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, a few minor comments
awaelchli
reviewed
Nov 8, 2022
awaelchli
approved these changes
Nov 8, 2022
Co-authored-by: Adrian Wälchli <[email protected]>
…lightning into expose_work_runner
Borda
pushed a commit
that referenced
this pull request
Nov 8, 2022
(cherry picked from commit f9a6573)
lexierule
pushed a commit
that referenced
this pull request
Nov 10, 2022
(cherry picked from commit f9a6573)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR exposes RunWorkExecutor and provides some default one for MultiNode Component.
Example with PyTorch. Processes are automatically spawned for the users.
Example with LightningLite.
Fixes #<issue_number>
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda