Skip to content

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Nov 9, 2022

What does this PR do?

Updates the examples to use the new CLI (no run method used). See #15506

Lightning Lite is also evolving to be more than just an onboarding tool for Trainer. The focus of the example has shifted away of teaching how to convert to a Lightning module and instead just focuses on showing how to integrate it with your existing PyTorch code.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @carmocca @justusschock @awaelchli

@awaelchli awaelchli added example fabric lightning.fabric.Fabric labels Nov 9, 2022
@awaelchli awaelchli added this to the v1.9 milestone Nov 9, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Nov 9, 2022
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the examples were used in CI, you'll need to update that too

@awaelchli
Copy link
Contributor Author

@carmocca Almost resolved. Just a tiny issue with the imports on the Lite GPU CI job.

@awaelchli awaelchli requested a review from carmocca November 10, 2022 02:40
@mergify mergify bot added the ready PRs ready to be merged label Nov 10, 2022
@awaelchli awaelchli requested a review from Borda November 10, 2022 04:30
@awaelchli awaelchli merged commit 2076746 into master Nov 10, 2022
@awaelchli awaelchli deleted the docs/examples-lite branch November 10, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
example fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants