Skip to content

Releasing 1.8.3 #15757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Nov 23, 2022
Merged

Releasing 1.8.3 #15757

merged 29 commits into from
Nov 23, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Nov 21, 2022 •
edited
Loading

What does this PR do?

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@Borda Borda added the release label Nov 21, 2022
@Borda Borda added this to the v1.8.x milestone Nov 21, 2022
Sherin Thomas and others added 14 commits November 21, 2022 21:42
@Borda
Torch inference mode for prediction (#15719)
a151ff5 
torch inference mode for prediction

(cherry picked from commit 08d14ec)
@ethanwharris @Borda @carmocca
[App] Update multi-node examples (#15700)
8b91b49 
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
(cherry picked from commit 8306797)
@yurijmikhalevich @Borda
feature(docs/app/lit_tabs): add works (#15731)
8e22225 
(cherry picked from commit 1a31d13)
@tchaton @Borda
[App] Fix VSCode IDE debugger (#15747)
6a4f221 
(cherry picked from commit 6714ca7)
@dependabot @Borda
Update tensorboard requirement from <2.11.0,>=2.9.1 to >=2.9.1,<2.12.…
669b28a 
…0 in /requirements (#15746)

Update tensorboard requirement in /requirements

Updates the requirements on [tensorboard](https://github.com/tensorflow/tensorboard) to permit the latest version.
- [Release notes](https://github.com/tensorflow/tensorboard/releases)
- [Changelog](https://github.com/tensorflow/tensorboard/blob/master/RELEASE.md)
- [Commits](tensorflow/tensorboard@2.9.1...2.11.0)

---
updated-dependencies:
- dependency-name: tensorboard
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 0b58b69)
@dependabot @Borda
Update beautifulsoup4 requirement from <=4.8.2 to <4.11.2 in /require…
49f3da7 
…ments (#15745)

* Update beautifulsoup4 requirement in /requirements

Updates the requirements on [beautifulsoup4](https://www.crummy.com/software/BeautifulSoup/bs4/) to permit the latest version.

---
updated-dependencies:
- dependency-name: beautifulsoup4
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

* Apply suggestions from code review

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <[email protected]>
(cherry picked from commit 1ffbe1b)
@ethanwharris @Borda
[App] Fix multi-node pytorch example CI (#15753)
9351d41 
(cherry picked from commit bc797fd)
@ethanwharris @Borda
[App] Improve LightningTrainerScript start-up time (#15751)
abf0a40 
(cherry picked from commit c2c1974)
@carmocca @Borda
Enable Probot CheckGroup v5 (#15670)
69f4aea 
(cherry picked from commit 6c8ee01)
@tchaton @Borda
[App] Enable properties for the Lightning flow (#15750)
636a46c 
(cherry picked from commit 5cfb176)
@Borda @tchaton @ethanwharris
test for Enable setting property (#15755)
0e6a3a3 
Co-authored-by: thomas chaton <[email protected]>
Co-authored-by: Ethan Harris <[email protected]>
(cherry picked from commit ba14038)
@lantiga @Borda
Move s3fs to cloud extras (#15729)
23ec3c4 
Co-authored-by: Luca Antiga <[email protected]>
(cherry picked from commit dd75906)
@awaelchli @Borda
Revert new Hydra launch behavior (#15737)
7d8d21b 
* revert new hydra cwd behavior
* remove debug statements
* changelog

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>

(cherry picked from commit 88b2e5a)
@justusschock @Borda
@akihironitta @lantiga
FCCV Docs (#15598)
eeb7166 
* add custom data iter docs

* add custom data iter docs

* Update docs/source-pytorch/data/custom_data_iterables.rst

* remove ToDevice

* nit

* Update docs/source-pytorch/data/custom_data_iterables.rst

Co-authored-by: Luca Antiga <[email protected]>

* clarification for @lantiga

* typo

* Update docs/source-pytorch/data/custom_data_iterables.rst

* Update docs/source-pytorch/data/custom_data_iterables.rst

* Update docs/source-pytorch/data/custom_data_iterables.rst

Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Akihiro Nitta <[email protected]>
Co-authored-by: Luca Antiga <[email protected]>
(cherry picked from commit 006fde9)
@Borda Borda requested a review from akihironitta as a code owner November 21, 2022 20:46
@lantiga @Borda
Switch from tensorboard to tensorboardx in logger (#15728)
eac6c3f 
* Switch from tensorboard to tensorboardx in logger
* Warn if log_graph is set to True but tensorboard is not installed
* Fix warning message formatting
* Apply suggestions from code review
* simplify for TBX as required pkg
* docs example
* chlog
* tbx 2.2

Co-authored-by: Luca Antiga <[email protected]>
Co-authored-by: William Falcon <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Jirka <[email protected]>

(cherry picked from commit 9c2eb52)
@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2022 •
edited
Loading

⛈️ Required checks status: Has failure 🔴

⚠️ This job will need to be re-run to merge your PR. If you do not have write access to the repository you can ask Lightning-AI/lai-frameworks to re-run it for you. If you push a new commit, all of CI will re-trigger ⚠️ If you have any other questions, you can reach out to carmocca for help.

Groups summary

🔴 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, pytorch, 3.8, 1.11) success ✅
pl-cpu (macOS-11, pytorch, 3.9, 1.12) success ✅
pl-cpu (macOS-11, pytorch, 3.10, 1.13) success ✅
pl-cpu (macOS-11, pytorch, 3.8, 1.9, oldest) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10) failure ❌
pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12) failure ❌
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.7, 1.9, oldest) success ✅
pl-cpu (windows-2022, pytorch, 3.9, 1.11) success ✅
pl-cpu (windows-2022, pytorch, 3.10, 1.12) success ✅
pl-cpu (windows-2022, pytorch, 3.10, 1.13) success ✅
pl-cpu (windows-2022, pytorch, 3.7, 1.9, oldest) success ✅
pl-cpu (slow, macOS-11, pytorch, 3.7, 1.11) success ✅
pl-cpu (slow, ubuntu-20.04, pytorch, 3.7, 1.11) success ✅
pl-cpu (slow, windows-2022, pytorch, 3.7, 1.11) success ✅
pl-cpu (macOS-11, lightning, 3.8, 1.13) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13) success ✅
pl-cpu (windows-2022, lightning, 3.8, 1.13) success ✅
🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) success ✅
🟡 pytorch_lightning: Benchmarks
Check ID Status
pytorch-lightning.Benchmark queued ⌛
🟢 pytorch_lightning: Azure HPU
Check ID Status
pytorch-lightning (HPUs) success ✅
🟢 pytorch_lightning: Azure IPU
Check ID Status
pytorch-lightning (IPUs) success ✅
🟢 pytorch_lightning: Docs
Check ID Status
make-doctest (pytorch) success ✅
make-html (pytorch) success ✅
🟡 pytorch_lightning: Docker
Check ID Status
build-cuda (3.9, 1.10, 11.3.1) success ✅
build-cuda (3.9, 1.11, 11.3.1) in_progress ⌛
build-cuda (3.9, 1.12, 11.6.1) in_progress ⌛
build-cuda (3.9, 1.13, 11.6.1) in_progress ⌛
build-hpu (1.5.0, 1.11.0) success ✅
build-ipu (3.9, 1.9) success ✅
build-NGC success ✅
build-pl (3.9, 1.10, 11.3.1) success ✅
build-pl (3.9, 1.11, 11.3.1) success ✅
build-pl (3.9, 1.12, 11.6.1) success ✅
build-pl (3.9, 1.13, 11.6.1) success ✅
build-xla (3.7, 1.12) success ✅
🟢 lightning_lite: CPU workflow
Check ID Status
lite-cpu (macOS-11, lite, 3.8, 1.11) success ✅
lite-cpu (macOS-11, lite, 3.9, 1.12) success ✅
lite-cpu (macOS-11, lite, 3.10, 1.13) success ✅
lite-cpu (macOS-11, lite, 3.7, 1.9, oldest) success ✅
lite-cpu (ubuntu-20.04, lite, 3.8, 1.10) success ✅
lite-cpu (ubuntu-20.04, lite, 3.9, 1.11) success ✅
lite-cpu (ubuntu-20.04, lite, 3.10, 1.12) success ✅
lite-cpu (ubuntu-20.04, lite, 3.10, 1.13) success ✅
lite-cpu (ubuntu-20.04, lite, 3.7, 1.9, oldest) success ✅
lite-cpu (windows-2022, lite, 3.9, 1.11) success ✅
lite-cpu (windows-2022, lite, 3.10, 1.12) success ✅
lite-cpu (windows-2022, lite, 3.10, 1.13) success ✅
lite-cpu (windows-2022, lite, 3.7, 1.9, oldest) success ✅
lite-cpu (macOS-11, lightning, 3.8, 1.13) success ✅
lite-cpu (ubuntu-20.04, lightning, 3.8, 1.13) success ✅
lite-cpu (windows-2022, lightning, 3.8, 1.13) success ✅
🔴 lightning_lite: Azure GPU
Check ID Status
lightning-lite (GPUs) failure ❌
🟢 lightning_app: Tests workflow
Check ID Status
app-pytest (macOS-11, app, 3.8, latest) success ✅
app-pytest (macOS-11, app, 3.8, oldest) success ✅
app-pytest (macOS-11, lightning, 3.9, latest) success ✅
app-pytest (ubuntu-20.04, app, 3.8, latest) success ✅
app-pytest (ubuntu-20.04, app, 3.8, oldest) success ✅
app-pytest (ubuntu-20.04, lightning, 3.9, latest) success ✅
app-pytest (windows-2022, app, 3.8, latest) success ✅
app-pytest (windows-2022, app, 3.8, oldest) success ✅
app-pytest (windows-2022, lightning, 3.8, latest) success ✅
🟢 lightning_app: Examples
Check ID Status
app-examples (macOS-11, app, 3.9, latest) success ✅
app-examples (macOS-11, app, 3.9, oldest) success ✅
app-examples (macOS-11, lightning, 3.9, latest) success ✅
app-examples (ubuntu-20.04, app, 3.9, latest) success ✅
app-examples (ubuntu-20.04, app, 3.9, oldest) success ✅
app-examples (ubuntu-20.04, lightning, 3.9, latest) success ✅
app-examples (windows-2022, app, 3.9, latest) success ✅
app-examples (windows-2022, app, 3.9, oldest) success ✅
app-examples (windows-2022, lightning, 3.9, latest) success ✅
🔴 lightning_app: Azure
Check ID Status
App.cloud-e2e failure ❌
🟢 lightning_app: Docs
Check ID Status
make-doctest (app) success ✅
make-html (app) success ✅
🟢 mypy
Check ID Status
mypy success ✅
🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.7) success ✅
install-pkg (ubuntu-22.04, app, 3.10) success ✅
install-pkg (ubuntu-22.04, lite, 3.7) success ✅
install-pkg (ubuntu-22.04, lite, 3.10) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.7) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.10) success ✅
install-pkg (ubuntu-22.04, lightning, 3.7) success ✅
install-pkg (ubuntu-22.04, lightning, 3.10) success ✅
install-pkg (macOS-12, app, 3.7) success ✅
install-pkg (macOS-12, app, 3.10) success ✅
install-pkg (macOS-12, lite, 3.7) success ✅
install-pkg (macOS-12, lite, 3.10) success ✅
install-pkg (macOS-12, pytorch, 3.7) success ✅
install-pkg (macOS-12, pytorch, 3.10) success ✅
install-pkg (macOS-12, lightning, 3.7) success ✅
install-pkg (macOS-12, lightning, 3.10) success ✅
install-pkg (windows-2022, app, 3.7) success ✅
install-pkg (windows-2022, app, 3.10) success ✅
install-pkg (windows-2022, lite, 3.7) success ✅
install-pkg (windows-2022, lite, 3.10) success ✅
install-pkg (windows-2022, pytorch, 3.7) success ✅
install-pkg (windows-2022, pytorch, 3.10) success ✅
install-pkg (windows-2022, lightning, 3.7) success ✅
install-pkg (windows-2022, lightning, 3.10) success ✅

This comment was automatically generated and updates for 60 minutes every 180 seconds.

Thank you for your contribution! 💜

carmocca and others added 8 commits November 22, 2022 16:42
@carmocca @Borda
Fix azure path excludes (#15756)
9f383cb 
Co-authored-by: Jirka Borovec <[email protected]>
(cherry picked from commit aef94ce)
@lantiga @Borda
Disable XSRF protection in StreamlitFrontend to support upload in loc…
50e2ec7 
…alhost (#15684)

* Enable CORS in StreamlitFrontend to support upload
* Only disable XSRF when running on localhost
* Update test
* Use utility fn to detect if localhost

Co-authored-by: Luca Antiga <[email protected]>
(cherry picked from commit ed3eef0)
@carmocca @Borda
Enable Probot CheckGroup v5.1 (#15763)
de7b37a 
(cherry picked from commit c55f80f)
@dependabot @Borda
Bump pytest from 7.1.3 to 7.2.0 in /requirements (#15677)
a2c7cce 
Bumps [pytest](https://github.com/pytest-dev/pytest) from 7.1.3 to 7.2.0.
- [Release notes](https://github.com/pytest-dev/pytest/releases)
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst)
- [Commits](pytest-dev/pytest@7.1.3...7.2.0)

---
updated-dependencies:
- dependency-name: pytest
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit cfb27bd)
@kaushikb11 @Borda
Fix the examples/app_dag App (#14359)
00e9292 
* Fix app dag example
* Add test
* Update doc
* Update tests/tests_app_examples/test_app_dag.py

Co-authored-by: Sherin Thomas <[email protected]>
(cherry picked from commit 2b61c92)
@Borda
mergify: drop ready for draft (#15766)
afa51e3 
(cherry picked from commit 1a07a9c)
@rlizzo @Borda
lightning delete cluster CLI command help text update (#15760)
555fe82 
* updated the lighting delete cluster CLI command help text output
* updated changelog
* typo fix
* Apply suggestions from code review

Co-authored-by: Jirka Borovec <[email protected]>
(cherry picked from commit 75b0573)
@rlizzo @Borda
Deduplicate top level lighting CLI command groups (#15761)
eeacf69 
* unify remove and delete command groups & the add and delete command groups
* added changelog
* fix tests
* Apply suggestions from code review

Co-authored-by: Jirka Borovec <[email protected]>
(cherry picked from commit 7b2788e)
@Borda Borda changed the title Releasing 1.8.3 [wip] Releasing 1.8.3 Nov 22, 2022
@mergify mergify bot added the ready PRs ready to be merged label Nov 22, 2022
@awaelchli
Copy link
Contributor

Note that the branch this PR is based on already contains broken tests due to the previous release #15698. Otherwise LGTM.

@Borda
Copy link
Member Author

Borda commented Nov 22, 2022

Note that the branch this PR is based on already contains broken tests due to the previous release #15698.

What shall we pick to fix it or do you suggest a completely custom fix? 🐰

tchaton
tchaton approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@rlizzo @Borda
Fix App Docs for lightning ssh-keys command (#15773)
ed26322 
fixed ssh-keys docs

(cherry picked from commit 317591d)
@lantiga lantiga merged commit 7d6cfb1 into release/stable Nov 23, 2022
@lantiga lantiga deleted the releasing/1.8.3 branch November 23, 2022 08:43
@nicolai86 nicolai86 mentioned this pull request Dec 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lantiga lantiga lantiga approved these changes

@tchaton tchaton tchaton approved these changes

@hhsecond hhsecond Awaiting requested review from hhsecond

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon williamFalcon is a code owner

@edenlightning edenlightning Awaiting requested review from edenlightning

+3 more reviewers

@awaelchli awaelchli awaelchli approved these changes

@carmocca carmocca carmocca approved these changes

@akihironitta akihironitta akihironitta approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready PRs ready to be merged release
Projects
None yet
Milestone
v1.8.x
Development

Successfully merging this pull request may close these issues.