Skip to content

Conversation

lightningforever
Copy link
Contributor

@lightningforever lightningforever commented Dec 20, 2022

What does this PR do?

Part of #16121

These utilities are needed in Lite and can be imported in PL from Lite. Tests were moved too. No implementation changes.

Does your PR introduce any breaking changes? If yes, please list them.

No, because all functions are marked as protected API.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Dec 20, 2022
@carmocca carmocca added this to the v1.9 milestone Dec 20, 2022
@lightningforever lightningforever mentioned this pull request Dec 20, 2022
11 tasks
@mergify mergify bot added the ready PRs ready to be merged label Dec 20, 2022
@awaelchli awaelchli enabled auto-merge (squash) December 20, 2022 17:00
@awaelchli awaelchli merged commit b52a594 into Lightning-AI:lite/debug Dec 20, 2022
@lightningforever lightningforever deleted the lite/debug-move-logger-utils branch December 20, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants