Skip to content

Sync with master changes #16169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Dec 22, 2022
Merged

Sync with master changes #16169

merged 17 commits into from
Dec 22, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Dec 22, 2022 •
edited by github-actions bot
Loading

What does this PR do?

git cherry-pick bf5fa3517dd7f3641b5c164a59c16d8ea5517ce2..8bc78a6596538a14bd04d246d45668b625f638b1

cc @Borda

@carmocca carmocca self-assigned this Dec 22, 2022
@carmocca carmocca changed the title Sync debug branch with master changes Sync with master changes Dec 22, 2022
@carmocca carmocca changed the base branch from master to lite/debug December 22, 2022 01:48
@mergify mergify bot removed the has conflicts label Dec 22, 2022
@awaelchli
Copy link
Contributor

It is very strange, that the previous PR ran test-on-tpus (fabric) (correctly), but this one somehow wants to go back to test-on-tpus (lite)which got renamed. cc @Borda

ethanwharris and others added 10 commits December 22, 2022 14:08
@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2022 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, pytorch, 3.8, 1.11) success ✅
pl-cpu (macOS-11, pytorch, 3.9, 1.12) success ✅
pl-cpu (macOS-11, pytorch, 3.10, 1.13) success ✅
pl-cpu (macOS-11, pytorch, 3.8, 1.10, oldest) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.7, 1.10, oldest) success ✅
pl-cpu (windows-2022, pytorch, 3.9, 1.11) success ✅
pl-cpu (windows-2022, pytorch, 3.10, 1.12) success ✅
pl-cpu (windows-2022, pytorch, 3.10, 1.13) success ✅
pl-cpu (windows-2022, pytorch, 3.7, 1.10, oldest) success ✅
pl-cpu (slow, macOS-11, pytorch, 3.7, 1.11) success ✅
pl-cpu (slow, ubuntu-20.04, pytorch, 3.7, 1.11) success ✅
pl-cpu (slow, windows-2022, pytorch, 3.7, 1.11) success ✅
pl-cpu (macOS-11, lightning, 3.8, 1.13) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13) success ✅
pl-cpu (windows-2022, lightning, 3.8, 1.13) success ✅

These checks are required after the changes to .actions/assistant.py, .github/workflows/ci-tests-pytorch.yml, src/lightning_fabric/__setup__.py, src/lightning_fabric/accelerators/__init__.py, src/lightning_fabric/accelerators/cuda.py, src/lightning_fabric/utilities/device_parser.py, requirements/pytorch/adjust-versions.py, requirements/pytorch/strategies.txt, src/pytorch_lightning/__setup__.py, src/pytorch_lightning/_graveyard/__init__.py, src/pytorch_lightning/_graveyard/loops.py, src/pytorch_lightning/accelerators/__init__.py, src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/pytorch_lightning/trainer/connectors/signal_connector.py, src/pytorch_lightning/trainer/trainer.py, src/pytorch_lightning/tuner/auto_gpu_select.py, src/pytorch_lightning/tuner/tuning.py, src/pytorch_lightning/utilities/migration/utils.py, tests/tests_pytorch/deprecated_api/test_remove_1-10.py, tests/tests_pytorch/deprecated_api/test_remove_1-9.py, tests/tests_pytorch/graveyard/test_loops.py, tests/tests_pytorch/test_cli.py, tests/tests_pytorch/trainer/properties/test_auto_gpu_select.py, tests/tests_pytorch/trainer/test_trainer.py, tests/tests_pytorch/tuner/test_lr_finder.py, tests/tests_pytorch/tuner/test_scale_batch_size.py, tests/tests_pytorch/tuner/test_tuning.py, tests/tests_pytorch/utilities/migration/test_migration.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) success ✅

These checks are required after the changes to .actions/assistant.py, .azure/gpu-tests-pytorch.yml, requirements/pytorch/adjust-versions.py, requirements/pytorch/strategies.txt, src/pytorch_lightning/__setup__.py, src/pytorch_lightning/_graveyard/__init__.py, src/pytorch_lightning/_graveyard/loops.py, src/pytorch_lightning/accelerators/__init__.py, src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/pytorch_lightning/trainer/connectors/signal_connector.py, src/pytorch_lightning/trainer/trainer.py, src/pytorch_lightning/tuner/auto_gpu_select.py, src/pytorch_lightning/tuner/tuning.py, src/pytorch_lightning/utilities/migration/utils.py, tests/tests_pytorch/deprecated_api/test_remove_1-10.py, tests/tests_pytorch/deprecated_api/test_remove_1-9.py, tests/tests_pytorch/graveyard/test_loops.py, tests/tests_pytorch/test_cli.py, tests/tests_pytorch/trainer/properties/test_auto_gpu_select.py, tests/tests_pytorch/trainer/test_trainer.py, tests/tests_pytorch/tuner/test_lr_finder.py, tests/tests_pytorch/tuner/test_scale_batch_size.py, tests/tests_pytorch/tuner/test_tuning.py, tests/tests_pytorch/utilities/migration/test_migration.py, src/lightning_fabric/__setup__.py, src/lightning_fabric/accelerators/__init__.py, src/lightning_fabric/accelerators/cuda.py, src/lightning_fabric/utilities/device_parser.py.

🟢 pytorch_lightning: Benchmarks
Check ID Status
pytorch-lightning.Benchmark success ✅

These checks are required after the changes to requirements/pytorch/adjust-versions.py, requirements/pytorch/strategies.txt.

🟢 pytorch_lightning: Azure HPU
Check ID Status
pytorch-lightning (HPUs) success ✅

These checks are required after the changes to .actions/assistant.py, src/lightning_fabric/__setup__.py, src/lightning_fabric/accelerators/__init__.py, src/lightning_fabric/accelerators/cuda.py, src/lightning_fabric/utilities/device_parser.py, requirements/pytorch/adjust-versions.py, requirements/pytorch/strategies.txt, src/pytorch_lightning/__setup__.py, src/pytorch_lightning/_graveyard/__init__.py, src/pytorch_lightning/_graveyard/loops.py, src/pytorch_lightning/accelerators/__init__.py, src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/pytorch_lightning/trainer/connectors/signal_connector.py, src/pytorch_lightning/trainer/trainer.py, src/pytorch_lightning/tuner/auto_gpu_select.py, src/pytorch_lightning/tuner/tuning.py, src/pytorch_lightning/utilities/migration/utils.py, tests/tests_pytorch/deprecated_api/test_remove_1-10.py, tests/tests_pytorch/deprecated_api/test_remove_1-9.py, tests/tests_pytorch/graveyard/test_loops.py, tests/tests_pytorch/test_cli.py, tests/tests_pytorch/trainer/properties/test_auto_gpu_select.py, tests/tests_pytorch/trainer/test_trainer.py, tests/tests_pytorch/tuner/test_lr_finder.py, tests/tests_pytorch/tuner/test_scale_batch_size.py, tests/tests_pytorch/tuner/test_tuning.py, tests/tests_pytorch/utilities/migration/test_migration.py.

🟢 pytorch_lightning: Azure IPU
Check ID Status
pytorch-lightning (IPUs) success ✅

These checks are required after the changes to .actions/assistant.py, .azure/ipu-tests.yml, src/lightning_fabric/__setup__.py, src/lightning_fabric/accelerators/__init__.py, src/lightning_fabric/accelerators/cuda.py, src/lightning_fabric/utilities/device_parser.py, requirements/pytorch/adjust-versions.py, requirements/pytorch/strategies.txt, src/pytorch_lightning/__setup__.py, src/pytorch_lightning/_graveyard/__init__.py, src/pytorch_lightning/_graveyard/loops.py, src/pytorch_lightning/accelerators/__init__.py, src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/pytorch_lightning/trainer/connectors/signal_connector.py, src/pytorch_lightning/trainer/trainer.py, src/pytorch_lightning/tuner/auto_gpu_select.py, src/pytorch_lightning/tuner/tuning.py, src/pytorch_lightning/utilities/migration/utils.py, tests/tests_pytorch/deprecated_api/test_remove_1-10.py, tests/tests_pytorch/deprecated_api/test_remove_1-9.py, tests/tests_pytorch/graveyard/test_loops.py, tests/tests_pytorch/test_cli.py, tests/tests_pytorch/trainer/properties/test_auto_gpu_select.py, tests/tests_pytorch/trainer/test_trainer.py, tests/tests_pytorch/tuner/test_lr_finder.py, tests/tests_pytorch/tuner/test_scale_batch_size.py, tests/tests_pytorch/tuner/test_tuning.py, tests/tests_pytorch/utilities/migration/test_migration.py.

🟢 pytorch_lightning: Docs
Check ID Status
make-doctest (pytorch) success ✅
make-html (pytorch) success ✅

These checks are required after the changes to src/pytorch_lightning/__setup__.py, src/pytorch_lightning/_graveyard/__init__.py, src/pytorch_lightning/_graveyard/loops.py, src/pytorch_lightning/accelerators/__init__.py, src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/pytorch_lightning/trainer/connectors/signal_connector.py, src/pytorch_lightning/trainer/trainer.py, src/pytorch_lightning/tuner/auto_gpu_select.py, src/pytorch_lightning/tuner/tuning.py, src/pytorch_lightning/utilities/migration/utils.py, docs/source-pytorch/accelerators/gpu_basic.rst, docs/source-pytorch/api_references.rst, docs/source-pytorch/clouds/fault_tolerant_training_basic.rst, docs/source-pytorch/clouds/fault_tolerant_training_expert.rst, docs/source-pytorch/common/trainer.rst, docs/source-pytorch/model/build_model.rst, .actions/assistant.py, .github/workflows/docs-checks.yml, requirements/pytorch/adjust-versions.py, requirements/pytorch/strategies.txt, setup.py.

🟢 pytorch_lightning: Docker
Check ID Status
build-cuda (3.9, 1.10, 11.3.1) success ✅
build-cuda (3.9, 1.11, 11.3.1) success ✅
build-cuda (3.9, 1.12, 11.6.1) success ✅
build-cuda (3.9, 1.13, 11.6.1) success ✅
build-hpu (1.5.0, 1.11.0) success ✅
build-ipu (3.9, 1.10) success ✅
build-NGC success ✅
build-pl (3.9, 1.10, 11.3.1) success ✅
build-pl (3.9, 1.11, 11.3.1) success ✅
build-pl (3.9, 1.12, 11.6.1) success ✅
build-pl (3.9, 1.13, 11.6.1) success ✅
build-xla (3.7, 1.12) success ✅

These checks are required after the changes to .actions/assistant.py, dockers/base-cuda/Dockerfile, dockers/release/Dockerfile, requirements/pytorch/adjust-versions.py, requirements/pytorch/strategies.txt, setup.py.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-11, fabric, 3.8, 1.11) success ✅
fabric-cpu (macOS-11, fabric, 3.9, 1.12) success ✅
fabric-cpu (macOS-11, fabric, 3.10, 1.13) success ✅
fabric-cpu (macOS-11, fabric, 3.7, 1.10, oldest) success ✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.10) success ✅
fabric-cpu (ubuntu-20.04, fabric, 3.9, 1.11) success ✅
fabric-cpu (ubuntu-20.04, fabric, 3.10, 1.12) success ✅
fabric-cpu (ubuntu-20.04, fabric, 3.10, 1.13) success ✅
fabric-cpu (ubuntu-20.04, fabric, 3.7, 1.10, oldest) success ✅
fabric-cpu (windows-2022, fabric, 3.9, 1.11) success ✅
fabric-cpu (windows-2022, fabric, 3.10, 1.12) success ✅
fabric-cpu (windows-2022, fabric, 3.10, 1.13) success ✅
fabric-cpu (windows-2022, fabric, 3.7, 1.10, oldest) success ✅
fabric-cpu (macOS-11, lightning, 3.8, 1.13) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.13) success ✅
fabric-cpu (windows-2022, lightning, 3.8, 1.13) success ✅

These checks are required after the changes to .actions/assistant.py, src/lightning_fabric/__setup__.py, src/lightning_fabric/accelerators/__init__.py, src/lightning_fabric/accelerators/cuda.py, src/lightning_fabric/utilities/device_parser.py, tests/tests_fabric/accelerators/test_cuda.py, .github/workflows/ci-tests-fabric.yml.

🟢 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) success ✅

These checks are required after the changes to .actions/assistant.py, .azure/gpu-tests-fabric.yml, src/lightning_fabric/__setup__.py, src/lightning_fabric/accelerators/__init__.py, src/lightning_fabric/accelerators/cuda.py, src/lightning_fabric/utilities/device_parser.py, tests/tests_fabric/accelerators/test_cuda.py.

🟢 lightning_app: Tests workflow
Check ID Status
app-pytest (macOS-11, app, 3.8, latest) success ✅
app-pytest (macOS-11, app, 3.8, oldest) success ✅
app-pytest (macOS-11, lightning, 3.9, latest) success ✅
app-pytest (ubuntu-20.04, app, 3.8, latest) success ✅
app-pytest (ubuntu-20.04, app, 3.8, oldest) success ✅
app-pytest (ubuntu-20.04, lightning, 3.9, latest) success ✅
app-pytest (windows-2022, app, 3.8, latest) success ✅
app-pytest (windows-2022, app, 3.8, oldest) success ✅
app-pytest (windows-2022, lightning, 3.8, latest) success ✅

These checks are required after the changes to .actions/assistant.py, .github/workflows/ci-tests-app.yml, src/lightning_app/__setup__.py, src/lightning_app/core/api.py, src/lightning_app/runners/cloud.py, src/lightning_app/storage/path.py, src/lightning_app/utilities/app_helpers.py, src/lightning_app/utilities/cloud.py, tests/tests_app/core/test_lightning_api.py, tests/tests_app/runners/test_cloud.py, setup.py.

🟢 lightning_app: Examples
Check ID Status
app-examples (macOS-11, app, 3.9, latest) success ✅
app-examples (macOS-11, app, 3.9, oldest) success ✅
app-examples (macOS-11, lightning, 3.9, latest) success ✅
app-examples (ubuntu-20.04, app, 3.9, latest) success ✅
app-examples (ubuntu-20.04, app, 3.9, oldest) success ✅
app-examples (ubuntu-20.04, lightning, 3.9, latest) success ✅
app-examples (windows-2022, app, 3.9, latest) success ✅
app-examples (windows-2022, app, 3.9, oldest) success ✅
app-examples (windows-2022, lightning, 3.9, latest) success ✅

These checks are required after the changes to .actions/assistant.py, .github/workflows/ci-examples-app.yml, src/lightning_app/__setup__.py, src/lightning_app/core/api.py, src/lightning_app/runners/cloud.py, src/lightning_app/storage/path.py, src/lightning_app/utilities/app_helpers.py, src/lightning_app/utilities/cloud.py, setup.py.

🟢 lightning_app: Azure
Check ID Status
App.cloud-e2e success ✅

These checks are required after the changes to .actions/assistant.py, .azure/app-cloud-e2e.yml, src/lightning_app/__setup__.py, src/lightning_app/core/api.py, src/lightning_app/runners/cloud.py, src/lightning_app/storage/path.py, src/lightning_app/utilities/app_helpers.py, src/lightning_app/utilities/cloud.py, setup.py.

🟢 lightning_app: Docs
Check ID Status
make-doctest (app) success ✅
make-html (app) success ✅

These checks are required after the changes to .actions/assistant.py, src/lightning_app/__setup__.py, src/lightning_app/core/api.py, src/lightning_app/runners/cloud.py, src/lightning_app/storage/path.py, src/lightning_app/utilities/app_helpers.py, src/lightning_app/utilities/cloud.py, .github/workflows/docs-checks.yml, setup.py.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to .actions/assistant.py, requirements/pytorch/adjust-versions.py, requirements/pytorch/strategies.txt, src/lightning/__setup__.py, src/lightning_app/__setup__.py, src/lightning_app/core/api.py, src/lightning_app/runners/cloud.py, src/lightning_app/storage/path.py, src/lightning_app/utilities/app_helpers.py, src/lightning_app/utilities/cloud.py, src/lightning_fabric/__setup__.py, src/lightning_fabric/accelerators/__init__.py, src/lightning_fabric/accelerators/cuda.py, src/lightning_fabric/utilities/device_parser.py, src/pytorch_lightning/__setup__.py, src/pytorch_lightning/_graveyard/__init__.py, src/pytorch_lightning/_graveyard/loops.py, src/pytorch_lightning/accelerators/__init__.py, src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/pytorch_lightning/trainer/connectors/signal_connector.py, src/pytorch_lightning/trainer/trainer.py, src/pytorch_lightning/tuner/auto_gpu_select.py, src/pytorch_lightning/tuner/tuning.py, src/pytorch_lightning/utilities/migration/utils.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.7) success ✅
install-pkg (ubuntu-22.04, app, 3.10) success ✅
install-pkg (ubuntu-22.04, fabric, 3.7) success ✅
install-pkg (ubuntu-22.04, fabric, 3.10) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.7) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.10) success ✅
install-pkg (ubuntu-22.04, lightning, 3.7) success ✅
install-pkg (ubuntu-22.04, lightning, 3.10) success ✅
install-pkg (ubuntu-22.04, notset, 3.7) success ✅
install-pkg (ubuntu-22.04, notset, 3.10) success ✅
install-pkg (macOS-12, app, 3.7) success ✅
install-pkg (macOS-12, app, 3.10) success ✅
install-pkg (macOS-12, fabric, 3.7) success ✅
install-pkg (macOS-12, fabric, 3.10) success ✅
install-pkg (macOS-12, pytorch, 3.7) success ✅
install-pkg (macOS-12, pytorch, 3.10) success ✅
install-pkg (macOS-12, lightning, 3.7) success ✅
install-pkg (macOS-12, lightning, 3.10) success ✅
install-pkg (macOS-12, notset, 3.7) success ✅
install-pkg (macOS-12, notset, 3.10) success ✅
install-pkg (windows-2022, app, 3.7) success ✅
install-pkg (windows-2022, app, 3.10) success ✅
install-pkg (windows-2022, fabric, 3.7) success ✅
install-pkg (windows-2022, fabric, 3.10) success ✅
install-pkg (windows-2022, pytorch, 3.7) success ✅
install-pkg (windows-2022, pytorch, 3.10) success ✅
install-pkg (windows-2022, lightning, 3.7) success ✅
install-pkg (windows-2022, lightning, 3.10) success ✅
install-pkg (windows-2022, notset, 3.7) success ✅
install-pkg (windows-2022, notset, 3.10) success ✅

These checks are required after the changes to .actions/assistant.py, .github/actions/pkg-install/action.yml, .github/workflows/_build-packages.yml, .github/workflows/ci-pkg-install.yml, setup.py, src/lightning/__setup__.py, src/lightning_app/__setup__.py, src/lightning_app/core/api.py, src/lightning_app/runners/cloud.py, src/lightning_app/storage/path.py, src/lightning_app/utilities/app_helpers.py, src/lightning_app/utilities/cloud.py, src/lightning_fabric/__setup__.py, src/lightning_fabric/accelerators/__init__.py, src/lightning_fabric/accelerators/cuda.py, src/lightning_fabric/utilities/device_parser.py, src/pytorch_lightning/__setup__.py, src/pytorch_lightning/_graveyard/__init__.py, src/pytorch_lightning/_graveyard/loops.py, src/pytorch_lightning/accelerators/__init__.py, src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/pytorch_lightning/trainer/connectors/signal_connector.py, src/pytorch_lightning/trainer/trainer.py, src/pytorch_lightning/tuner/auto_gpu_select.py, src/pytorch_lightning/tuner/tuning.py, src/pytorch_lightning/utilities/migration/utils.py, requirements/pytorch/adjust-versions.py, requirements/pytorch/strategies.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

edenlightning and others added 4 commits December 22, 2022 18:00
@edenlightning @carmocca
Update fault_tolerant_training_basic.rst (#16012)
3787377
@Al3xDo @awaelchli
@pre-commit-ci @Borda @carmocca
Fix incorrect tuner error message (#16104)
648520f 
Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Jirka <[email protected]>
Fixes #15855
@Borda @carmocca
unify extras & minor CI cleaning: move env. var (#15942)
de19307 
Co-authored-by: Carlos Mocholí <[email protected]>
@Borda @carmocca
update chlog after 1.8.6 (#16174)
d952a80
@awaelchli @carmocca
Deprecate auto_select_gpus (#16147)
69633eb 
Co-authored-by: Carlos Mocholí <[email protected]>
@carmocca carmocca enabled auto-merge (squash) December 22, 2022 17:46
@carmocca carmocca merged commit 1ad68e5 into lite/debug Dec 22, 2022
@carmocca carmocca deleted the sync/lite branch December 22, 2022 19:24
@mergify mergify bot added the ready PRs ready to be merged label Dec 22, 2022
carmocca added a commit that referenced this pull request Jan 4, 2023
@carmocca
Sync with master changes (#16169)
75c7377
carmocca added a commit that referenced this pull request Jan 4, 2023
@carmocca
Sync with master changes (#16169)
7d090dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@edenlightning edenlightning Awaiting requested review from edenlightning

@tchaton tchaton Awaiting requested review from tchaton

@lantiga lantiga Awaiting requested review from lantiga

@hhsecond hhsecond Awaiting requested review from hhsecond

@ethanwharris ethanwharris Awaiting requested review from ethanwharris

@justusschock justusschock Awaiting requested review from justusschock

@akihironitta akihironitta Awaiting requested review from akihironitta

+1 more reviewer

@awaelchli awaelchli awaelchli approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@carmocca carmocca

Labels
ready PRs ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@carmocca @awaelchli @Borda @ethanwharris @mauvilsa @edenlightning @Al3xDo