Skip to content

Remove the deprecated code in pl.utilities.device_parser #16412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Remove the deprecated code in pl.utilities.device_parser #16412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae27311
Remove the deprecated code in `pl.utilities.device_parser`
carmocca Jan 18, 2023
c8cb5df
#
carmocca Jan 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/pytorch_lightning/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).

- Removed the deprecated code in `pl.utilities.xla_device` ([#16404](https://github.com/Lightning-AI/lightning/pull/16404))

- Removed the deprecated code in `pl.utilities.device_parser` ([#16412](https://github.com/Lightning-AI/lightning/pull/16412))

- Mark the `forward_module` argument as required ([#16386](https://github.com/Lightning-AI/lightning/pull/16386))
* Removed the deprecated `pl_module` argument from the distributed module wrappers
* Removed the deprecated `pytorch_lightning.overrides.base.unwrap_lightning_module` function
Expand Down
79 changes: 0 additions & 79 deletions src/pytorch_lightning/utilities/device_parser.py
View file
Open in desktop

This file was deleted.

32 changes: 0 additions & 32 deletions tests/tests_pytorch/deprecated_api/test_remove_2-0.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,6 @@
)
from pytorch_lightning.utilities.cloud_io import atomic_save, get_filesystem, load
from pytorch_lightning.utilities.data import has_iterable_dataset, has_len
from pytorch_lightning.utilities.device_parser import (
determine_root_gpu_device,
is_cuda_available,
num_cuda_devices,
parse_cpu_cores,
parse_gpu_ids,
parse_hpus,
parse_tpu_cores,
)
from pytorch_lightning.utilities.optimizer import optimizer_to_device, optimizers_to_device
from pytorch_lightning.utilities.seed import pl_worker_init_function, reset_seed, seed_everything

Expand Down Expand Up @@ -104,29 +95,6 @@ def test_v1_10_deprecated_data_utilities():
has_len(DataLoader(RandomDataset(2, 4)))


def test_v1_10_deprecated_device_parser_utilities():
with pytest.deprecated_call(match="device_parser.determine_root_gpu_device` has been deprecated in v1.8.0"):
determine_root_gpu_device(None)

with pytest.deprecated_call(match="device_parser.is_cuda_available` has been deprecated in v1.8.0"):
is_cuda_available()

with pytest.deprecated_call(match="device_parser.num_cuda_devices` has been deprecated in v1.8.0"):
num_cuda_devices()

with pytest.deprecated_call(match="device_parser.parse_hpus` has been deprecated in v1.8.0"):
parse_hpus(1)

with pytest.deprecated_call(match="device_parser.parse_cpu_cores` has been deprecated in v1.8.0"):
parse_cpu_cores(1)

with pytest.deprecated_call(match="device_parser.parse_gpu_ids` has been deprecated in v1.8.0"):
parse_gpu_ids(None)

with pytest.deprecated_call(match="device_parser.parse_tpu_cores` has been deprecated in v1.8.0"):
parse_tpu_cores(None)


def test_v1_10_deprecated_optimizer_utilities():
with pytest.deprecated_call(match="optimizer.optimizers_to_device` has been deprecated in v1.8.0"):
optimizers_to_device([torch.optim.Adam(torch.nn.Linear(1, 1).parameters())], "cpu")
Expand Down