Skip to content

Two fixes for handling edge cases in MLflow logging #16451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 23, 2023
Merged

Two fixes for handling edge cases in MLflow logging #16451

merged 8 commits into from
Jan 23, 2023

Conversation

senarvi
Copy link
Contributor

@senarvi senarvi commented Jan 20, 2023 •
edited
Loading

What does this PR do?

  • Long parameter values are truncated, instead of not logged at all.
  • In case there are more than 100 parameters, they are logged in chunks.

In another pull request it was discussed that it's better to truncate the parameter values, rather than not log them at all, if the length exceeds the MLflow limit. I found another problem with the recently introduced change: A batch logging request can contain at most 100 parameters. This PR will log the parameters in chunks of 100 parameters, if there are more than 100.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Two fixes for handling edge cases in MLflow logging
945fbf8 
* Long parameter values are truncated, instead of not logged at all.
* In case there are more than 100 parameters, they are logged in chunks.
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jan 20, 2023
@senarvi
Copy link
Contributor Author

senarvi commented Jan 20, 2023

Let me know if you think that this small fix should be added to CHANGELOG.

awaelchli
awaelchli reviewed Jan 20, 2023
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Minor comments

Let me know if you think that this small fix should be added to CHANGELOG.

Yes please that would be appreciated. For fixes we always prefer to have it documented in the changelog. Thank you

@awaelchli awaelchli added logger: mlflow community This PR is from the community bug Something isn't working labels Jan 20, 2023
@awaelchli awaelchli added this to the v1.9.x milestone Jan 20, 2023
@awaelchli awaelchli self-assigned this Jan 20, 2023
@senarvi
Copy link
Contributor Author

senarvi commented Jan 23, 2023

Let me know if you think that this small fix should be added to CHANGELOG.

Yes please that would be appreciated. For fixes we always prefer to have it documented in the changelog. Thank you

Done.

awaelchli
awaelchli approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@Borda Borda merged commit 9346151 into Lightning-AI:master Jan 23, 2023
@mergify mergify bot added the ready PRs ready to be merged label Jan 23, 2023
Borda pushed a commit that referenced this pull request Feb 9, 2023
@pre-commit-ci @Borda
Two fixes for handling edge cases in MLflow logging (#16451)
cc8a278 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 9346151)
lantiga pushed a commit that referenced this pull request Feb 10, 2023
@pre-commit-ci @lantiga
Two fixes for handling edge cases in MLflow logging (#16451)
0ea6b48 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 9346151)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@carmocca carmocca Awaiting requested review from carmocca

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

+1 more reviewer

@awaelchli awaelchli awaelchli approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@awaelchli awaelchli

Labels
bug Something isn't working community This PR is from the community logger: mlflow pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Milestone
v1.9.x
Development

Successfully merging this pull request may close these issues.
3 participants
@senarvi @awaelchli @Borda