Skip to content

Drop support for PyTorch 1.10 #16492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Feb 1, 2023
Merged

Drop support for PyTorch 1.10 #16492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
37bf62a
Drop support for PyTorch 1.10
carmocca Jan 25, 2023
9c5edd6
CHANGELOG
carmocca Jan 25, 2023
7be4234
READMEs
carmocca Jan 25, 2023
e5cb5cf
mypy
carmocca Jan 25, 2023
73c2789
Merge branch 'master' into ci/drop-pt-1.20
carmocca Jan 30, 2023
4c0680c
ls
carmocca Jan 30, 2023
315c1e4
Merge branch 'master' into ci/drop-pt-1.20
carmocca Jan 31, 2023
f91a1a1
New poplar version
carmocca Jan 31, 2023
b6b3794
Fixed tests
carmocca Jan 31, 2023
e9924c0
links
Borda Jan 31, 2023
bc4bacc
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 31, 2023
1999b81
skip azure badges
carmocca Jan 31, 2023
fc93146
Table
carmocca Jan 31, 2023
7c32b54
Merge branch 'master' into ci/drop-pt-1.20
carmocca Jan 31, 2023
fdf8abc
Merge branch 'master' into ci/drop-pt-1.20
carmocca Feb 1, 2023
b93f23a
Matching dockerfiles
carmocca Feb 1, 2023
c2a3409
Merge branch 'master' into ci/drop-pt-1.20
carmocca Feb 1, 2023
9d11cdc
Drop unnecessary channels and packages
carmocca Feb 1, 2023
9618f73
Push nightly
carmocca Feb 1, 2023
9c47d82
Undo unrelated changes
carmocca Feb 1, 2023
132020c
Merge branch 'master' into ci/drop-pt-1.20
carmocca Feb 1, 2023
c8f8564
Revert "Push nightly"
carmocca Feb 1, 2023
c1cc0bf
Merge branch 'master' into ci/drop-pt-1.20
carmocca Feb 1, 2023
8e06b7f
Merge branch 'master' into ci/drop-pt-1.20
carmocca Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .azure/ipu-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ pr:
variables:
- name: poplar_sdk
# https://docs.graphcore.ai/projects/poptorch-user-guide/en/latest/installation.html#version-compatibility
value: "poplar_sdk-ubuntu_20_04-3.0.0+1145-1b114aac3a"
value: "poplar_sdk-ubuntu_20_04-3.1.0+1205-58b501c780"

jobs:
- job: testing
Expand All @@ -44,7 +44,10 @@ jobs:
clean: all

steps:
- script: tar -xvzf /opt/poplar/${{ variables.poplar_sdk }}.tar.gz
- script: |
ls -la /mnt/public/packages
ls -la /opt/poplar
tar -xvzf /opt/poplar/${{ variables.poplar_sdk }}.tar.gz
displayName: "Extract Poplar SDK"

- script: |
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/1_bug_report.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ body:
#- Lightning Component (e.g. Trainer, LightningModule, LightningApp, LightningWork, LightningFlow):
#- PyTorch Lightning Version (e.g., 1.5.0):
#- Lightning App Version (e.g., 0.5.2):
#- PyTorch Version (e.g., 1.10):
#- PyTorch Version (e.g., 2.0):
#- Python version (e.g., 3.9):
#- OS (e.g., Linux):
#- CUDA/cuDNN version:
Expand Down
18 changes: 7 additions & 11 deletions .github/checkgroup.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,15 @@ subprojects:
- "pl-cpu (macOS-11, pytorch, 3.8, 1.11)"
- "pl-cpu (macOS-11, pytorch, 3.9, 1.12)"
- "pl-cpu (macOS-11, pytorch, 3.10, 1.13)"
- "pl-cpu (macOS-11, pytorch, 3.8, 1.10, oldest)"
- "pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10)"
- "pl-cpu (macOS-11, pytorch, 3.8, 1.11, oldest)"
- "pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11)"
- "pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12)"
- "pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13)"
- "pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10, oldest)"
- "pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.11, oldest)"
- "pl-cpu (windows-2022, pytorch, 3.9, 1.11)"
- "pl-cpu (windows-2022, pytorch, 3.10, 1.12)"
- "pl-cpu (windows-2022, pytorch, 3.10, 1.13)"
- "pl-cpu (windows-2022, pytorch, 3.8, 1.10, oldest)"
- "pl-cpu (windows-2022, pytorch, 3.8, 1.11, oldest)"
- "pl-cpu (slow, macOS-11, pytorch, 3.8, 1.11)"
- "pl-cpu (slow, ubuntu-20.04, pytorch, 3.8, 1.11)"
- "pl-cpu (slow, windows-2022, pytorch, 3.8, 1.11)"
Expand Down Expand Up @@ -162,14 +161,12 @@ subprojects:
- "!*.md"
- "!**/*.md"
checks:
- "build-cuda (3.9, 1.10, 11.3.1)"
- "build-cuda (3.9, 1.11, 11.3.1)"
- "build-cuda (3.9, 1.12, 11.6.1)"
- "build-cuda (3.9, 1.13, 11.7.1)"
- "build-hpu (1.5.0, 1.11.0)"
- "build-ipu (3.9, 1.10)"
- "build-ipu (3.9, 1.13)"
- "build-NGC"
- "build-pl (3.9, 1.10, 11.3.1)"
- "build-pl (3.9, 1.11, 11.3.1)"
- "build-pl (3.9, 1.12, 11.6.1)"
- "build-pl (3.9, 1.13, 11.7.1)"
Expand All @@ -193,16 +190,15 @@ subprojects:
- "fabric-cpu (macOS-11, fabric, 3.8, 1.11)"
- "fabric-cpu (macOS-11, fabric, 3.9, 1.12)"
- "fabric-cpu (macOS-11, fabric, 3.10, 1.13)"
- "fabric-cpu (macOS-11, fabric, 3.8, 1.10, oldest)"
- "fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.10)"
- "fabric-cpu (macOS-11, fabric, 3.8, 1.11, oldest)"
- "fabric-cpu (ubuntu-20.04, fabric, 3.9, 1.11)"
- "fabric-cpu (ubuntu-20.04, fabric, 3.10, 1.12)"
- "fabric-cpu (ubuntu-20.04, fabric, 3.10, 1.13)"
- "fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.10, oldest)"
- "fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.11, oldest)"
- "fabric-cpu (windows-2022, fabric, 3.9, 1.11)"
- "fabric-cpu (windows-2022, fabric, 3.10, 1.12)"
- "fabric-cpu (windows-2022, fabric, 3.10, 1.13)"
- "fabric-cpu (windows-2022, fabric, 3.8, 1.10, oldest)"
- "fabric-cpu (windows-2022, fabric, 3.8, 1.11, oldest)"
- "fabric-cpu (macOS-11, lightning, 3.8, 1.13)"
- "fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.13)"
- "fabric-cpu (windows-2022, lightning, 3.8, 1.13)"
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/ci-dockers-pytorch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ jobs:
include:
# We only release one docker image per PyTorch version.
# The matrix here is the same as the one in release-docker.yml.
- {python_version: "3.9", pytorch_version: "1.10", cuda_version: "11.3.1"}
- {python_version: "3.9", pytorch_version: "1.11", cuda_version: "11.3.1"}
- {python_version: "3.9", pytorch_version: "1.12", cuda_version: "11.6.1"}
- {python_version: "3.9", pytorch_version: "1.13", cuda_version: "11.7.1"}
Expand Down Expand Up @@ -103,7 +102,6 @@ jobs:
include:
# These are the base images for PL release docker images,
# so include at least all of the combinations in release-dockers.yml.
- {python_version: "3.9", pytorch_version: "1.10", cuda_version: "11.3.1"}
- {python_version: "3.9", pytorch_version: "1.11", cuda_version: "11.3.1"}
- {python_version: "3.9", pytorch_version: "1.12", cuda_version: "11.6.1"}
- {python_version: "3.9", pytorch_version: "1.13", cuda_version: "11.7.1"}
Expand Down Expand Up @@ -143,7 +141,7 @@ jobs:
matrix:
include:
# the config used in 'dockers/ci-runner-ipu/Dockerfile'
- {python_version: "3.9", pytorch_version: "1.10"}
- {python_version: "3.9", pytorch_version: "1.13"}
steps:
- uses: actions/checkout@v3
- uses: docker/setup-buildx-action@v2
Expand Down
9 changes: 3 additions & 6 deletions .github/workflows/ci-tests-fabric.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,8 @@ jobs:
fail-fast: false
matrix:
include:
# assign python and pytorch version combinations to operating systems (arbitrarily)
# note: there's no distribution of torch==1.10 for Python>=3.10
- {os: "macOS-11", pkg-name: "fabric", python-version: "3.8", pytorch-version: "1.11"}
- {os: "macOS-11", pkg-name: "fabric", python-version: "3.9", pytorch-version: "1.12"}
- {os: "ubuntu-20.04", pkg-name: "fabric", python-version: "3.8", pytorch-version: "1.10"}
- {os: "ubuntu-20.04", pkg-name: "fabric", python-version: "3.9", pytorch-version: "1.11"}
- {os: "ubuntu-20.04", pkg-name: "fabric", python-version: "3.10", pytorch-version: "1.12"}
- {os: "windows-2022", pkg-name: "fabric", python-version: "3.9", pytorch-version: "1.11"}
Expand All @@ -52,9 +49,9 @@ jobs:
- {os: "ubuntu-20.04", pkg-name: "fabric", python-version: "3.10", pytorch-version: "1.13"}
- {os: "windows-2022", pkg-name: "fabric", python-version: "3.10", pytorch-version: "1.13"}
# "oldest" versions tests, only on minimum Python
- {os: "macOS-11", pkg-name: "fabric", python-version: "3.8", pytorch-version: "1.10", requires: "oldest"}
- {os: "ubuntu-20.04", pkg-name: "fabric", python-version: "3.8", pytorch-version: "1.10", requires: "oldest"}
- {os: "windows-2022", pkg-name: "fabric", python-version: "3.8", pytorch-version: "1.10", requires: "oldest"}
- {os: "macOS-11", pkg-name: "fabric", python-version: "3.8", pytorch-version: "1.11", requires: "oldest"}
- {os: "ubuntu-20.04", pkg-name: "fabric", python-version: "3.8", pytorch-version: "1.11", requires: "oldest"}
- {os: "windows-2022", pkg-name: "fabric", python-version: "3.8", pytorch-version: "1.11", requires: "oldest"}
# "lightning" installs the monolithic package
- {os: "macOS-11", pkg-name: "lightning", python-version: "3.8", pytorch-version: "1.13"}
- {os: "ubuntu-20.04", pkg-name: "lightning", python-version: "3.8", pytorch-version: "1.13"}
Expand Down
9 changes: 3 additions & 6 deletions .github/workflows/ci-tests-pytorch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,8 @@ jobs:
fail-fast: false
matrix:
include:
# assign python and pytorch version combinations to operating systems (arbitrarily)
# note: there's no distribution of torch==1.10 for Python>=3.10
- {os: "macOS-11", pkg-name: "pytorch", python-version: "3.8", pytorch-version: "1.11"}
- {os: "macOS-11", pkg-name: "pytorch", python-version: "3.9", pytorch-version: "1.12"}
- {os: "ubuntu-20.04", pkg-name: "pytorch", python-version: "3.8", pytorch-version: "1.10"}
- {os: "ubuntu-20.04", pkg-name: "pytorch", python-version: "3.9", pytorch-version: "1.11"}
- {os: "ubuntu-20.04", pkg-name: "pytorch", python-version: "3.10", pytorch-version: "1.12"}
- {os: "windows-2022", pkg-name: "pytorch", python-version: "3.9", pytorch-version: "1.11"}
Expand All @@ -57,9 +54,9 @@ jobs:
- {os: "ubuntu-20.04", pkg-name: "pytorch", python-version: "3.10", pytorch-version: "1.13"}
- {os: "windows-2022", pkg-name: "pytorch", python-version: "3.10", pytorch-version: "1.13"}
# "oldest" versions tests, only on minimum Python
- {os: "macOS-11", pkg-name: "pytorch", python-version: "3.8", pytorch-version: "1.10", requires: "oldest"}
- {os: "ubuntu-20.04", pkg-name: "pytorch", python-version: "3.8", pytorch-version: "1.10", requires: "oldest"}
- {os: "windows-2022", pkg-name: "pytorch", python-version: "3.8", pytorch-version: "1.10", requires: "oldest"}
- {os: "macOS-11", pkg-name: "pytorch", python-version: "3.8", pytorch-version: "1.11", requires: "oldest"}
- {os: "ubuntu-20.04", pkg-name: "pytorch", python-version: "3.8", pytorch-version: "1.11", requires: "oldest"}
- {os: "windows-2022", pkg-name: "pytorch", python-version: "3.8", pytorch-version: "1.11", requires: "oldest"}
# run test under SLOW label
- {type: "slow", os: "macOS-11", pkg-name: "pytorch", python-version: "3.8", pytorch-version: "1.11"}
- {type: "slow", os: "ubuntu-20.04", pkg-name: "pytorch", python-version: "3.8", pytorch-version: "1.11"}
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/markdown.links.config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
"ignorePatterns": [
{
"pattern": "^https://github.com/Lightning-AI/lightning/pull/.*"
},
{
"pattern": ".*https://dev.azure.com/Lightning-AI/lightning/_apis/build/status/.*"
}
],
"httpHeaders": [
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/release-docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ jobs:
matrix:
include:
# We only release one docker image per PyTorch version.
- {python_version: "3.9", pytorch_version: "1.10", cuda_version: "11.3.1"}
- {python_version: "3.9", pytorch_version: "1.11", cuda_version: "11.3.1"}
- {python_version: "3.9", pytorch_version: "1.12", cuda_version: "11.6.1"}
- {python_version: "3.9", pytorch_version: "1.13", cuda_version: "11.7.1"}
Expand Down
Loading