Skip to content

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 26, 2023

What does this PR do?

extend trigger range...
follow-up of #16420

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @carmocca @akihironitta @Borda

@Borda Borda added the ci Continuous Integration label Jan 26, 2023
@Borda Borda requested a review from a team January 26, 2023 14:09
@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2023

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning: Flagships
Check ID Status
app-flagships (flashy, Lightning-Universe/Flashy-app) success

These checks are required after the changes to .github/workflows/ci-flagship-apps.yml.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@mergify mergify bot added the ready PRs ready to be merged label Jan 26, 2023
@Borda Borda merged commit c3a9bf0 into master Jan 26, 2023
@Borda Borda deleted the ci/flagship branch January 26, 2023 14:59
@Borda Borda added this to the v1.9.x milestone Feb 1, 2023
Borda added a commit that referenced this pull request Feb 9, 2023
(cherry picked from commit c3a9bf0)
lantiga pushed a commit that referenced this pull request Feb 10, 2023
(cherry picked from commit c3a9bf0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants