Skip to content

Conversation

Borda
Copy link
Member

@Borda Borda commented Feb 10, 2023

What does this PR do?

Rolling space for the next release...

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @carmocca @justusschock @awaelchli

@Borda Borda added this to the v1.9.x milestone Feb 10, 2023
@github-actions github-actions bot added app (removed) Generic label for Lightning App package fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels Feb 10, 2023
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #16718 (3d69e46) into release/stable (c24b4bb) will not change coverage.
The diff coverage is n/a.

❗ Current head 3d69e46 differs from pull request most recent head 212a410. Consider uploading reports for the commit 212a410 to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##           release/stable   #16718   +/-   ##
===============================================
  Coverage              82%      82%           
===============================================
  Files                 473      473           
  Lines               35080    35080           
===============================================
  Hits                28635    28635           
  Misses               6445     6445           

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2023

⚡ Required checks status: All passing 🟢

Groups summary

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to src/version.info.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.7) success
install-pkg (ubuntu-22.04, app, 3.10) success
install-pkg (ubuntu-22.04, fabric, 3.7) success
install-pkg (ubuntu-22.04, fabric, 3.10) success
install-pkg (ubuntu-22.04, pytorch, 3.7) success
install-pkg (ubuntu-22.04, pytorch, 3.10) success
install-pkg (ubuntu-22.04, lightning, 3.7) success
install-pkg (ubuntu-22.04, lightning, 3.10) success
install-pkg (ubuntu-22.04, notset, 3.7) success
install-pkg (ubuntu-22.04, notset, 3.10) success
install-pkg (macOS-12, app, 3.7) success
install-pkg (macOS-12, app, 3.10) success
install-pkg (macOS-12, fabric, 3.7) success
install-pkg (macOS-12, fabric, 3.10) success
install-pkg (macOS-12, pytorch, 3.7) success
install-pkg (macOS-12, pytorch, 3.10) success
install-pkg (macOS-12, lightning, 3.7) success
install-pkg (macOS-12, lightning, 3.10) success
install-pkg (macOS-12, notset, 3.7) success
install-pkg (macOS-12, notset, 3.10) success
install-pkg (windows-2022, app, 3.7) success
install-pkg (windows-2022, app, 3.10) success
install-pkg (windows-2022, fabric, 3.7) success
install-pkg (windows-2022, fabric, 3.10) success
install-pkg (windows-2022, pytorch, 3.7) success
install-pkg (windows-2022, pytorch, 3.10) success
install-pkg (windows-2022, lightning, 3.7) success
install-pkg (windows-2022, lightning, 3.10) success
install-pkg (windows-2022, notset, 3.7) success
install-pkg (windows-2022, notset, 3.10) success

These checks are required after the changes to src/version.info.

🟢 link-check
Check ID Status
markdown-link-check success

These checks are required after the changes to src/lightning_app/CHANGELOG.md, src/lightning_fabric/CHANGELOG.md, src/pytorch_lightning/CHANGELOG.md.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@mergify mergify bot added the ready PRs ready to be merged label Feb 10, 2023
@Borda Borda marked this pull request as draft February 10, 2023 15:17
@mergify mergify bot removed the ready PRs ready to be merged label Feb 10, 2023
@Borda
Copy link
Member Author

Borda commented Feb 10, 2023

pending on release fix: #16720

@Borda Borda marked this pull request as ready for review February 10, 2023 18:45
@mergify mergify bot added the ready PRs ready to be merged label Feb 10, 2023
@Borda Borda enabled auto-merge (squash) February 10, 2023 18:46
@Borda Borda merged commit 3add657 into release/stable Feb 10, 2023
@Borda Borda deleted the releasing/1.9.2dev branch February 10, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants