Skip to content

Add more pytree tests #16825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 21, 2023
Merged

Add more pytree tests #16825

merged 2 commits into from
Feb 21, 2023

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Feb 21, 2023 •
edited by github-actions bot
Loading

What does this PR do?

Adding test coverage.
Resolve false positive TODO

cc @Borda

@carmocca carmocca added tests pl Generic label for PyTorch Lightning package labels Feb 21, 2023
@carmocca carmocca added this to the 2.0 milestone Feb 21, 2023
@carmocca carmocca self-assigned this Feb 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2023 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, lightning, 3.8, 1.11) success ✅
pl-cpu (macOS-11, lightning, 3.9, 1.12) success ✅
pl-cpu (macOS-11, lightning, 3.10, 1.13) success ✅
pl-cpu (macOS-11, lightning, 3.8, 1.11, oldest) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 1.11) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.12) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest) success ✅
pl-cpu (windows-2022, lightning, 3.9, 1.11) success ✅
pl-cpu (windows-2022, lightning, 3.10, 1.12) success ✅
pl-cpu (windows-2022, lightning, 3.10, 1.13) success ✅
pl-cpu (windows-2022, lightning, 3.8, 1.11, oldest) success ✅
pl-cpu (macOS-11, pytorch, 3.8, 1.13) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13) success ✅
pl-cpu (windows-2022, pytorch, 3.8, 1.13) success ✅

These checks are required after the changes to tests/tests_pytorch/utilities/test_combined_loader.py, tests/tests_pytorch/utilities/test_pytree.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) success ✅

These checks are required after the changes to tests/tests_pytorch/utilities/test_combined_loader.py, tests/tests_pytorch/utilities/test_pytree.py.

🟢 pytorch_lightning: Azure HPU
Check ID Status
pytorch-lightning (HPUs) success ✅

These checks are required after the changes to tests/tests_pytorch/utilities/test_combined_loader.py, tests/tests_pytorch/utilities/test_pytree.py.

🟢 pytorch_lightning: Azure IPU
Check ID Status
pytorch-lightning (IPUs) success ✅

These checks are required after the changes to tests/tests_pytorch/utilities/test_combined_loader.py, tests/tests_pytorch/utilities/test_pytree.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@carmocca carmocca mentioned this pull request Feb 21, 2023
Merged
10 tasks
awaelchli
awaelchli approved these changes Feb 21, 2023
View reviewed changes
@mergify mergify bot added the ready PRs ready to be merged label Feb 21, 2023
@carmocca carmocca merged commit 2bd54e4 into master Feb 21, 2023
@carmocca carmocca deleted the tests/add-pytree branch February 21, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

+1 more reviewer

@awaelchli awaelchli awaelchli approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@carmocca carmocca

Labels
pl Generic label for PyTorch Lightning package ready PRs ready to be merged tests
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@carmocca @awaelchli @Borda