Exclude some examples from docs navigation #17081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
force-pushed
the
docs/exclude-examples
branch
from
657eccc to
3b1dd25
Compare
Borda
reviewed
Mar 14, 2023
Borda
approved these changes
Mar 14, 2023
for more information, see https://pre-commit.ci
awaelchli
requested review from
williamFalcon,
lantiga and
carmocca
as code owners
⚡ Required checks status: All passing 🟢Groups summary🟢 pytorch_lightning: Docs
These checks are required after the changes to Thank you for your contribution! 💜
|
carmocca
approved these changes
Mar 14, 2023
Borda
requested changes
Mar 15, 2023
There was a problem hiding this comment.
let's wait for the commit when all updated notebooks are build
https://dev.azure.com/Lightning-AI/Tutorials/_build/results?buildId=144811&view=results
Borda
approved these changes
Mar 15, 2023
lantiga
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We are updating the course notebooks (Lightning-AI/tutorials#232) as well as the rest of the examples (Lightning-AI/tutorials#233) to Lightning 2.0. However, some examples turned out to be problematic, and we decided to temporarily exclude them until they are updated. The goal is to release 2.0 with docs that have valid tutorials.
cc @Borda