[pre-commit.ci] pre-commit suggestions #20035

pre-commit-ci · 2024-07-02T00:03:07Z

updates:

📚 Documentation preview 📚: https://pytorch-lightning--20035.org.readthedocs.build/en/20035/

updates: - [github.com/pre-commit/pre-commit-hooks: v4.5.0 → v4.6.0](pre-commit/pre-commit-hooks@v4.5.0...v4.6.0) - [github.com/codespell-project/codespell: v2.2.6 → v2.3.0](codespell-project/codespell@v2.2.6...v2.3.0) - [github.com/astral-sh/ruff-pre-commit: v0.3.5 → v0.5.0](astral-sh/ruff-pre-commit@v0.3.5...v0.5.0) - [github.com/pre-commit/mirrors-prettier: v3.1.0 → v4.0.0-alpha.8](pre-commit/mirrors-prettier@v3.1.0...v4.0.0-alpha.8)

github-actions · 2024-07-02T00:03:28Z

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-13, lightning, 3.8, 2.1, oldest)	success	✅
pl-cpu (macOS-14, lightning, 3.10, 2.1)	success	✅
pl-cpu (macOS-14, lightning, 3.10, 2.2)	success	✅
pl-cpu (macOS-14, lightning, 3.10, 2.3)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 2.1, oldest)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.1)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.2)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.3)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 2.1, oldest)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 2.1)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 2.2)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 2.3)	success	✅
pl-cpu (macOS-14, pytorch, 3.8, 2.1)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 2.1)	success	✅
pl-cpu (windows-2022, pytorch, 3.8, 2.1)	success	✅
pl-cpu (macOS-12, pytorch, 3.11, 2.1)	success	✅
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.1)	success	✅
pl-cpu (windows-2022, pytorch, 3.11, 2.1)	success	✅

These checks are required after the changes to src/lightning/fabric/loggers/tensorboard.py, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/strategies/model_parallel.py, src/lightning/pytorch/callbacks/progress/progress_bar.py, src/lightning/pytorch/callbacks/progress/rich_progress.py, src/lightning/pytorch/callbacks/stochastic_weight_avg.py, src/lightning/pytorch/core/datamodule.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/plugins/precision/deepspeed.py, src/lightning/pytorch/profilers/pytorch.py, src/lightning/pytorch/strategies/model_parallel.py, src/lightning/pytorch/strategies/strategy.py, src/lightning/pytorch/utilities/_pytree.py, tests/tests_pytorch/helpers/utils.py.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs) (testing Lightning \| latest)	success	✅
pytorch-lightning (GPUs) (testing PyTorch \| latest)	success	✅

These checks are required after the changes to src/lightning/pytorch/callbacks/progress/progress_bar.py, src/lightning/pytorch/callbacks/progress/rich_progress.py, src/lightning/pytorch/callbacks/stochastic_weight_avg.py, src/lightning/pytorch/core/datamodule.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/plugins/precision/deepspeed.py, src/lightning/pytorch/profilers/pytorch.py, src/lightning/pytorch/strategies/model_parallel.py, src/lightning/pytorch/strategies/strategy.py, src/lightning/pytorch/utilities/_pytree.py, tests/tests_pytorch/helpers/utils.py, src/lightning/fabric/loggers/tensorboard.py, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/strategies/model_parallel.py.

🟢 pytorch_lightning: Benchmarks

Check ID	Status
lightning.Benchmarks	success	✅

These checks are required after the changes to src/lightning/fabric/loggers/tensorboard.py, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/strategies/model_parallel.py, src/lightning/pytorch/callbacks/progress/progress_bar.py, src/lightning/pytorch/callbacks/progress/rich_progress.py, src/lightning/pytorch/callbacks/stochastic_weight_avg.py, src/lightning/pytorch/core/datamodule.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/plugins/precision/deepspeed.py, src/lightning/pytorch/profilers/pytorch.py, src/lightning/pytorch/strategies/model_parallel.py, src/lightning/pytorch/strategies/strategy.py, src/lightning/pytorch/utilities/_pytree.py.

🟢 fabric: Docs

Check ID	Status
docs-make (fabric, doctest)	success	✅
docs-make (fabric, html)	success	✅

These checks are required after the changes to src/lightning/fabric/loggers/tensorboard.py, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/strategies/model_parallel.py.

🟢 pytorch_lightning: Docs

Check ID	Status
docs-make (pytorch, doctest)	success	✅
docs-make (pytorch, html)	success	✅

These checks are required after the changes to src/lightning/pytorch/callbacks/progress/progress_bar.py, src/lightning/pytorch/callbacks/progress/rich_progress.py, src/lightning/pytorch/callbacks/stochastic_weight_avg.py, src/lightning/pytorch/core/datamodule.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/plugins/precision/deepspeed.py, src/lightning/pytorch/profilers/pytorch.py, src/lightning/pytorch/strategies/model_parallel.py, src/lightning/pytorch/strategies/strategy.py, src/lightning/pytorch/utilities/_pytree.py, docs/source-pytorch/past_versions.rst.

🟢 lightning_fabric: CPU workflow

Check ID	Status
fabric-cpu (macOS-13, lightning, 3.8, 2.1, oldest)	success	✅
fabric-cpu (macOS-14, lightning, 3.11, 2.1)	success	✅
fabric-cpu (macOS-14, lightning, 3.11, 2.2)	success	✅
fabric-cpu (macOS-14, lightning, 3.10, 2.3)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 2.1, oldest)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.1)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.2)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.3)	success	✅
fabric-cpu (windows-2022, lightning, 3.8, 2.1, oldest)	success	✅
fabric-cpu (windows-2022, lightning, 3.11, 2.1)	success	✅
fabric-cpu (windows-2022, lightning, 3.11, 2.2)	success	✅
fabric-cpu (windows-2022, lightning, 3.11, 2.3)	success	✅
fabric-cpu (macOS-14, fabric, 3.8, 2.1)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 2.1)	success	✅
fabric-cpu (windows-2022, fabric, 3.8, 2.1)	success	✅
fabric-cpu (macOS-12, fabric, 3.11, 2.1)	success	✅
fabric-cpu (ubuntu-22.04, fabric, 3.11, 2.1)	success	✅
fabric-cpu (windows-2022, fabric, 3.11, 2.1)	success	✅

These checks are required after the changes to src/lightning/fabric/loggers/tensorboard.py, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/strategies/model_parallel.py.

🟢 lightning_fabric: Azure GPU

Check ID	Status
lightning-fabric (GPUs) (testing Fabric \| latest)	success	✅
lightning-fabric (GPUs) (testing Lightning \| latest)	success	✅

These checks are required after the changes to examples/fabric/reinforcement_learning/train_fabric.py, examples/fabric/reinforcement_learning/train_fabric_decoupled.py, examples/fabric/reinforcement_learning/train_torch.py, src/lightning/fabric/loggers/tensorboard.py, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/strategies/model_parallel.py.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to src/lightning/fabric/loggers/tensorboard.py, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/strategies/model_parallel.py, src/lightning/pytorch/callbacks/progress/progress_bar.py, src/lightning/pytorch/callbacks/progress/rich_progress.py, src/lightning/pytorch/callbacks/stochastic_weight_avg.py, src/lightning/pytorch/core/datamodule.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/plugins/precision/deepspeed.py, src/lightning/pytorch/profilers/pytorch.py, src/lightning/pytorch/strategies/model_parallel.py, src/lightning/pytorch/strategies/strategy.py, src/lightning/pytorch/utilities/_pytree.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, fabric, 3.8)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.11)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.8)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.11)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.8)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.11)	success	✅
install-pkg (ubuntu-22.04, notset, 3.8)	success	✅
install-pkg (ubuntu-22.04, notset, 3.11)	success	✅
install-pkg (macOS-12, fabric, 3.8)	success	✅
install-pkg (macOS-12, fabric, 3.11)	success	✅
install-pkg (macOS-12, pytorch, 3.8)	success	✅
install-pkg (macOS-12, pytorch, 3.11)	success	✅
install-pkg (macOS-12, lightning, 3.8)	success	✅
install-pkg (macOS-12, lightning, 3.11)	success	✅
install-pkg (macOS-12, notset, 3.8)	success	✅
install-pkg (macOS-12, notset, 3.11)	success	✅
install-pkg (windows-2022, fabric, 3.8)	success	✅
install-pkg (windows-2022, fabric, 3.11)	success	✅
install-pkg (windows-2022, pytorch, 3.8)	success	✅
install-pkg (windows-2022, pytorch, 3.11)	success	✅
install-pkg (windows-2022, lightning, 3.8)	success	✅
install-pkg (windows-2022, lightning, 3.11)	success	✅
install-pkg (windows-2022, notset, 3.8)	success	✅
install-pkg (windows-2022, notset, 3.11)	success	✅

These checks are required after the changes to src/lightning/fabric/loggers/tensorboard.py, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/strategies/model_parallel.py, src/lightning/pytorch/callbacks/progress/progress_bar.py, src/lightning/pytorch/callbacks/progress/rich_progress.py, src/lightning/pytorch/callbacks/stochastic_weight_avg.py, src/lightning/pytorch/core/datamodule.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/plugins/precision/deepspeed.py, src/lightning/pytorch/profilers/pytorch.py, src/lightning/pytorch/strategies/model_parallel.py, src/lightning/pytorch/strategies/strategy.py, src/lightning/pytorch/utilities/_pytree.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

for more information, see https://pre-commit.ci

codecov · 2024-07-02T00:19:40Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90%. Comparing base (3730e98) to head (903d5b3).
Report is 68 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #20035   +/-   ##
=======================================
  Coverage      90%      90%           
=======================================
  Files         266      266           
  Lines       22939    22939           
=======================================
+ Hits        20719    20720    +1     
+ Misses       2220     2219    -1

.pre-commit-config.yaml

pre-commit-ci bot requested review from lantiga, Borda, tchaton, awaelchli and justusschock as code owners July 2, 2024 00:03

[pre-commit.ci] auto fixes from pre-commit.com hooks

a850e34

for more information, see https://pre-commit.ci

pre-commit-ci bot requested a review from ethanwharris as a code owner July 2, 2024 00:03

github-actions bot added fabric lightning.fabric.Fabric app (removed) Generic label for Lightning App package pl Generic label for PyTorch Lightning package labels Jul 2, 2024

Borda reviewed Jul 2, 2024

View reviewed changes

.pre-commit-config.yaml Outdated Show resolved Hide resolved

Apply suggestions from code review

8203514

Borda approved these changes Jul 2, 2024

View reviewed changes

mergify bot added the has conflicts label Jul 5, 2024

Merge branch 'master' into pre-commit-ci-update-config

9b59f9c

awaelchli added this to the 2.4 milestone Jul 5, 2024

mergify bot removed the has conflicts label Jul 5, 2024

resolve precommit warnings

903d5b3

awaelchli requested a review from williamFalcon as a code owner July 5, 2024 15:30

github-actions bot added docs Documentation related ci Continuous Integration labels Jul 5, 2024

awaelchli merged commit a40affb into master Jul 5, 2024

awaelchli deleted the pre-commit-ci-update-config branch July 5, 2024 16:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[pre-commit.ci] pre-commit suggestions #20035

[pre-commit.ci] pre-commit suggestions #20035

Uh oh!

pre-commit-ci bot commented Jul 2, 2024 •

edited by github-actions bot

Loading

Uh oh!

github-actions bot commented Jul 2, 2024 •

edited

Loading

Uh oh!

codecov bot commented Jul 2, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

[pre-commit.ci] pre-commit suggestions #20035

[pre-commit.ci] pre-commit suggestions #20035

Uh oh!

Conversation

pre-commit-ci bot commented Jul 2, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚡ Required checks status: All passing 🟢

Groups summary

Uh oh!

codecov bot commented Jul 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

pre-commit-ci bot commented Jul 2, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Jul 2, 2024 •

edited

Loading

codecov bot commented Jul 2, 2024 •

edited

Loading