-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Fix advanced profiler for python >=3.12 #20809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
@relativityhd can we pls add a test for this case |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://lightning.ai/docs/pytorch/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Discord. Thank you for your contributions. |
@Borda Sorry, haven't seen your comment. |
@bhimrazy mind have a look here, pls 🐿️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I’ll add a minimal test — something simple with nested settings should be fine.
Hi @deependujha, could you pls check if you're able to add the changelog? - Fixed `AdvancedProfiler` to handle nested profiling actions for Python 3.12+ ([#20809](https://github.com/Lightning-AI/pytorch-lightning/pull/20809)) I started getting a 403 error on my end. |
* Fix advanced profiler for python >=3.12 * test: add compatibility test for nested profiling in AdvancedProfiler (Python 3.12+) * Update src/lightning/pytorch/profilers/advanced.py * changelog --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Deependu <[email protected]> Co-authored-by: Bhimraj Yadav <[email protected]> (cherry picked from commit 11968ba)
* Fix advanced profiler for python >=3.12 * test: add compatibility test for nested profiling in AdvancedProfiler (Python 3.12+) * Update src/lightning/pytorch/profilers/advanced.py * changelog --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Deependu <[email protected]> Co-authored-by: Bhimraj Yadav <[email protected]> (cherry picked from commit 11968ba)
What does this PR do?
Fixes #19983
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20809.org.readthedocs.build/en/20809/