Fix save_last behavior in absence of validation
#20960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pl
for more information, see https://pre-commit.ci
baskrahmer
changed the title
save_last behavior in absence of validation
baskrahmer
requested review from
lantiga,
Borda,
tchaton,
justusschock and
ethanwharris
as code owners
Borda
approved these changes
Aug 8, 2025
Borda
pushed a commit
that referenced
this pull request
Aug 13, 2025
* Implement test to reproduce the issue * Implement fix * chlog --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Jirka B <[email protected]> (cherry picked from commit 72bb751)
Borda
pushed a commit
that referenced
this pull request
Aug 13, 2025
* Implement test to reproduce the issue * Implement fix * chlog --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Jirka B <[email protected]> (cherry picked from commit 72bb751)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #20200
Still need to update changelog
📚 Documentation preview 📚: https://pytorch-lightning--20960.org.readthedocs.build/en/20960/