Skip to content

fix mis-alignment column while using rich model summary in DeepSpeedstrategy #21100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 21, 2025
Merged

fix mis-alignment column while using rich model summary in DeepSpeedstrategy #21100

merged 5 commits into from
Aug 21, 2025

Conversation

GdoongMathew
Copy link
Contributor

@GdoongMathew GdoongMathew commented Aug 20, 2025 •
edited by Borda
Loading

What does this PR do?

fix #21099

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21100.org.readthedocs.build/en/21100/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 20, 2025
@Borda Borda changed the title fix mis-alignment column while using rich model summary in DeepSpeed … fix mis-alignment column while using rich model summary in DeepSpeedstrategy Aug 21, 2025
@Borda Borda merged commit 2460746 into Lightning-AI:master Aug 21, 2025
84 of 90 checks passed
Borda added a commit that referenced this pull request Aug 28, 2025
@GdoongMathew @Borda @SkafteNicki
fix mis-alignment column while using rich model summary in `DeepSpeed…
da37ff2 
…strategy` (#21100)

* fix mis-alignment column while using rich model summary in DeepSpeed strategy.
* test: add minimum gpu requirement in `test_deepspeed_summary_with_rich_model_summary`
* chlog

---------

Co-authored-by: Jirka B <[email protected]>
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
(cherry picked from commit 2460746)
lantiga pushed a commit that referenced this pull request Aug 29, 2025
@GdoongMathew @Borda
@SkafteNicki @lantiga
fix mis-alignment column while using rich model summary in `DeepSpeed…
72cc522 
…strategy` (#21100)

* fix mis-alignment column while using rich model summary in DeepSpeed strategy.
* test: add minimum gpu requirement in `test_deepspeed_summary_with_rich_model_summary`
* chlog

---------

Co-authored-by: Jirka B <[email protected]>
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
(cherry picked from commit 2460746)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

+1 more reviewer

@rittik9 rittik9 rittik9 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
pl Generic label for PyTorch Lightning package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mis-aligned information in RichModelSummary with `DeepSpeedStrategy
4 participants
@GdoongMathew @Borda @SkafteNicki @rittik9